Skip to content

Share the text-security masking check between the two captures #104

Open

Description

@morisil

Found in the review of the capture-live-form-state branch.

"Is this field masked?" is decided twice: it != null && it != "none" in CapturePage.kt (SnapshotDom.formState) and !isNullOrEmpty() && != "none" in ElementToSemanticEvents.kt (isMasked).
They already disagree on an empty string, and it is the kind of drift the new CLAUDE.md entry warns about (content decisions belong in one function both producers call).

Fix: add e.g. public fun isMaskingTextSecurity(value: String?): Boolean to FormControls.kt and call it from both.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions