Skip to content

Drop type prefixes on is-checks in #92 code (CSR convention) #98

Description

@morisil

Follow-up from the second review of #92.

Two is checks in new code keep the type prefix. CLAUDE.md says to write context-sensitive-resolution form from the start:

  • markanywhere-html/src/commonMain/kotlin/ExpressEmphasisInMarkdown.kt:110: event is SemanticEvent.Mark. The same file's when uses a bare is Mark.
  • markanywhere-render/src/commonMain/kotlin/MarkdownRendering.kt (openInline): frame !is BlockFrame.Inline, next to a bare frame is TaggedInline.

Drop the prefixes, unless CSR's fallback rule makes a name ambiguous there (see the CLAUDE.md note on Value.Map).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions