Conversation
Points the review workflow at the xemantic/.github experiment branch and plants a deliberate bug (isHtmlBlank: all -> any) for the review to find. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
morisil
added a commit
that referenced
this pull request
Sep 27, 2026
Reverted right after the test on #84 — the action only runs a workflow identical to the default branch's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Confirmed — this function has multiple real call sites (whitespace collapsing, actionable-element labeling, blank-inline-formatting dropping), so the bug is live and impactful, not just cosmetic. [
{
"file": "markanywhere-html-spec/src/commonMain/kotlin/HtmlWhitespace.kt",
"line": 43,
"summary": "`isHtmlBlank()` uses `any` instead of `all`, so it now returns true if a string merely *contains* HTML whitespace anywhere, rather than being *entirely* whitespace — inverting the intended semantics and contradicting its own doc comment (\"every character is HTML whitespace\").",
"failure_scenario": "For non-blank text with an embedded space/tab/newline, e.g. \"Fundstelle openJur\" or \"§ 823\" (with an ordinary space), `isHtmlBlank()` now returns `true` instead of `false`. Downstream this makes `HtmlWhitespaceNormalization.kt:104` treat real content as blank/pending whitespace (merging or dropping visible text), `LabelActionableElements.kt:207` treat a text node with any space in it as not counting as a label (an `<a>` with normal multi-word text could be judged unlabelled and get a placeholder or be misjudged), and `DropBlankInlineFormatting.kt:69` treat non-blank text as blank and strip formatting/mark pairs that actually have real content — e.g. `<em>Fundstelle openJur</em>` would be dropped as if it were empty, since almost every real sentence contains at least one whitespace character."
}
]Note: this is a throwaway/test PR (per its description) with the Posted by the workflow: the review agent finished without commenting. |
Member
Author
|
Test done: the built-in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway PR for testing whether Claude Code's built-in
/code-review --commentworks fromclaude-code-action..github/workflows/claude-code-review.ymlpoints at the experiment branchxemantic/.github@claude-review-builtin-test. That branch runs/code-review medium --comment <PR>withshow_full_output: true.isHtmlBlankhas a deliberate bug (all→any) for the review to find.Close without merging once the run has been inspected.
🤖 Generated with Claude Code