Repository navigation
Update tooling and dependencies - #48
Conversation
- Gradle wrapper 9.6.1 -> 9.7.1 - Kotlin 2.4.10 -> 2.4.20 - ASM 9.9.1 -> 9.10.1 - JReleaser plugin 1.25.0 -> 1.26.0 - binary-compatibility-validator 0.18.1 -> 0.18.2 - xemantic-conventions plugin 0.7.0 -> 0.7.1 - refresh yarn.lock for the new Kotlin JS tooling Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ReviewThis is a routine, mechanical dependency/tooling bump — reviewed the full diff across Code quality / best practices
Potential issues
Security
Test coverage
Overall: looks safe to merge. Only soft suggestion is the JS-tooling major-version transitive bumps noted above, if this template ships a non-trivial Kotlin/JS target worth a manual look. |
Force fast-uri 3.1.6, js-yaml 4.3.2, serialize-javascript 7.0.5, diff 8.0.3 and qs 6.16.0 for both the JS and the wasm yarn workspaces, and start tracking the wasm yarn.lock alongside the JS one. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ReviewReviewed the diff (Gradle wrapper bump, Kotlin 2.4.20, ASM/JReleaser/BCV/conventions-plugin bumps, and the npm Overall: looks good. Clean, well-scoped tooling update with clear rationale. Code quality
Correctness / verification
Security
Test coverage
Minor / nice-to-have
No blocking issues found. |
ReviewThis is a routine dependency-maintenance PR (Gradle wrapper, Kotlin, ASM, JReleaser, BCV, xemantic-conventions bumps + Dependabot npm pins). No production source changed. Overall it's clean and well-documented; a few notes below. Code quality / build script
Potential issues
Security
Test coverage
Nothing blocking. The major-version |
JReleaser is now compatible with the configuration cache, so it is enabled in gradle.properties together with explicit JVM args, and the --no-configuration-cache flag is removed from the CI workflows. CLAUDE.md documents two harmless warnings that surface with this setup. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ReviewSolid, well-documented dependency/tooling bump. The A few things worth double-checking before merge:
No security concerns — the yarn Nice attention to documenting the "why" in CLAUDE.md rather than just making the change silently. |
The flagged npm packages belong to mocha, karma and webpack, which only run tests and never ship in the published artifacts. Forcing patched versions pinned majors the tooling never declared support for, so the resolutions are removed and the lock files regenerated. The alerts are to be dismissed on GitHub instead, as documented in CLAUDE.md. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ReviewOverall this is a clean, mechanical dependency/tooling bump with a reasonable verification story (full Stale/broken
|
Summary
yarn.lockregenerated viakotlinUpgradeYarnLockfor the new Kotlin JS toolingAlready at latest: xemantic-kotlin-test 1.17.5, Dokka 2.2.0, maven-publish 0.37.0, version-catalog-update 1.1.1.
Dependabot alerts
All 12 open alerts point at transitive npm packages of the Kotlin/JS test tooling in
kotlin-js-store/yarn.lock.The two webpack alerts are already fixed by the regenerated lock (webpack 5.108.1).
The rest are pinned via yarn
resolution(...)entries inbuild.gradle.kts, applied to both the JS and the wasm yarn workspace:kotlin-js-store/wasm/yarn.lockwas never committed before and is now tracked too.rootPackageJson/wasmRootPackageJsondo not track resolutions as task inputs, so they must be forced with--rerunafter changing them — documented inCLAUDE.mdand in a comment in the build script.Verification
Full
./gradlew buildpasses locally, including all test targets (mocha-based JS and wasm tests included) andapiCheck.🤖 Generated with Claude Code