ci(lint): use golangci-lint v2.13 for Go 1.27 support - #23
Conversation
The lint job installs the stable Go toolchain, which now resolves to Go 1.27. golangci-lint v2.11 is built with Go 1.26 and panics with "file requires newer Go version go1.27" when type-checking the newer standard library. v2.13.0 is the first release built with Go 1.27 support.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe CI workflow now includes changes to ChangesCI workflow update
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The workflow update has no identified issue preventing merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Without this, changes to the lint or test job configuration are not exercised until an unrelated Go change lands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 30.99% 36.51% +5.51%
==========================================
Files 50 49 -1
Lines 5307 4820 -487
==========================================
+ Hits 1645 1760 +115
+ Misses 3396 3060 -336
+ Partials 266 0 -266 🚀 New features to boost your workflow:
|
Summary
versioninput from v2.11 to v2.13.go-version: stable, which now resolves to Go 1.27.1. golangci-lint v2.11 is built with Go 1.26 and panics withfile requires newer Go version go1.27 (application built with go1.26)when it type-checks the 1.27 standard library. This is why Lint fails on feat(worktree): create and manage development worktrees #14 and feat(cli): visual and UX polish across all commands #15 and would fail on main today; main's last passing Lint run (17 August) used Go 1.26.6..github/workflows/ci.ymlto the workflow's own path filters so changes to the lint or test jobs are exercised by CI, the same way ci: publish PHP 8.1–8.3 images #22 did for the image workflow. Without this the first commit here would not have run Lint at all.Testing
Test (race)failed on this PR, but that failure is pre-existing onmain(its 17 August run failed the same way): parallel tests incmd/xfrace on viper's package-level singleton. The fix is theconfig.Initmutex commit in feat(worktree): create and manage development worktrees #14 (f1b4a48). A cherry-pick of that commit was pushed to this branch after the merge and did not land; it will arrive with feat(worktree): create and manage development worktrees #14.Checklist