Add Turnstile timing to search stats - #468
Merged
Merged
Conversation
Co-authored-by: xenodus <xenodus@gmail.com>
Co-authored-by: xenodus <xenodus@gmail.com>
Co-authored-by: xenodus <xenodus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surfaces Cloudflare Turnstile challenge time as its own row in the search stats Client timing table, separate from session mint (GET
/sessionfetch) and search response.Changes
Code
apiSession.js: MeasureturnstileDurationMsaroundrequestTurnstileToken();sessionMintDurationMsnow covers only the/sessionfetch (excluding Turnstile).useSearch.js,searchUrl.js,App.jsx: PlumbturnstileDurationMsthrough search state and browser history snapshots.SearchStats.jsx: Show a Turnstile row when timing is > 0 (hidden when Turnstile is disabled or the session was already cached).Docs
docs/api-abuse-mitigation.md: Turnstile in intro; browser sequence diagram shows Lambda → Cloudflaresiteverify; Cloudflare Turnstile subsection documents frontend + backend roles and error responses; search-stats client-timing note.docs/architecture.md: Backend Turnstile verification in Lambda section; system diagram showsSearchLambda → siteverify; external services table covers browser + Lambda; Browser session and search explains two-sided control.README.md,AGENTS.md: Turnstile in API abuse-mitigation overview.Testing
make test(Go) — passgo fix ./...— no changesVITE_TURNSTILE_SITE_KEYis configured and a fresh session mint runs during search.Privacy policy
No change — no new data collection (Turnstile was already disclosed in the privacy modal).