Repository navigation
Conversation
FIELDS_BY_KIND lists `instances` for most kinds, but the inspector only renders fields that belong to a FIELD_GROUPS entry, and `instances` was in none, so it was silently filtered out. Scaling out was unreachable from the panel. Add it to "How much it can handle", ahead of slots per instance. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@Mrkewl is attempting to deploy a commit to the breakscale OSS Program Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes #96.
Adds
instancesto the "How much it can handle" group inFIELD_GROUPS, so the Instances field appears in the inspector again, above slots per instance.Why
FIELDS_BY_KINDlistsinstancesfor most kinds (service, db, cache, lb, worker, cdn and others), andFIELD_SPECSdefines it ("How many copies of this component are running. This is what an autoscaler adds and removes."). But the inspector only renders fields that belong to someFIELD_GROUPSentry, andinstanceswas in none. So it was filtered out silently and scaling out couldn't be done from the panel. The comment aboveFIELD_GROUPSsays the groups partition each kind's list.instanceswas the field that fell through.Found while working through the "Keep it warm" challenge: the hint suggests more database capacity, but only slots per instance could be edited.
Verification
New
Inspector.instances.test.tsxrenders the panel for service, db, cache, lb and worker and asserts anInstanceslabel. It fails 5/5 onmainand passes with this change.Covers the multi-selection panel too, since it uses the same
FIELD_GROUPS.bun run testpasses (58 files, 1254 tests)bun run typecheckandbun run lintpass (lint: pre-existing warnings only, none in touched files)bun run buildpassesScreenshot attached, if anything visual changed (the field now shows as the first row under "How much it can handle")
🤖 Generated with Claude Code