Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ jobs:
test "$(git rev-parse HEAD)" = "$(git rev-list -n 1 "${release_tag}")"
test -z "$(git status --porcelain)"

version="$(./mvnw -q help:evaluate -Dexpression=project.version -DforceStdout | tail -n 1)"
version="$(
./mvnw -q help:evaluate -Dexpression=project.version -DforceStdout |
sed -n 's/^\[INFO\] \[stdout\] //p' |
tail -n 1
)"
test "${{ inputs.release_tag }}" = "v${version}"
case "${version}" in
*-SNAPSHOT)
Expand Down Expand Up @@ -122,7 +126,11 @@ jobs:
./mvnw -B -Prelease -DskipTests -Dmaven.repo.local="${consumer_pom_repository}" \
-Dgpg.passphrase="${GPG_PASSPHRASE}" install

version="$(./mvnw -q help:evaluate -Dexpression=project.version -DforceStdout | tail -n 1)"
version="$(
./mvnw -q help:evaluate -Dexpression=project.version -DforceStdout |
sed -n 's/^\[INFO\] \[stdout\] //p' |
tail -n 1
)"
bash scripts/verify-consumer-pom.sh "${consumer_pom_repository}" "${version}" \
"$(command -v mvn)" "$(pwd)/mvnw"
echo "CONSUMER_POM_REPOSITORY=${consumer_pom_repository}" >> "${GITHUB_ENV}"
Expand Down
64 changes: 62 additions & 2 deletions scripts/verify-release-workflow-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,24 @@ jobs:
ref: ${{ inputs.release_tag }}
- name: Verify immutable release source
run: |
version="$(./mvnw -q help:evaluate -Dexpression=project.version -DforceStdout | tail -n 1)"
version="$(
./mvnw -q help:evaluate -Dexpression=project.version -DforceStdout |
sed -n 's/^\[INFO\] \[stdout\] //p' |
tail -n 1
)"
test "${{ inputs.release_tag }}" = "v${version}"
test -z "$(git status --porcelain)"
- name: Verify complete CI
run: gh run view 1 --json jobs
- run: ./mvnw -B -Prelease -DskipTests verify
- name: Verify Maven Central Consumer POMs
run: bash scripts/verify-consumer-pom.sh /tmp/repository 1.0.0 mvn ./mvnw
run: |
version="$(
./mvnw -q help:evaluate -Dexpression=project.version -DforceStdout |
sed -n 's/^\[INFO\] \[stdout\] //p' |
tail -n 1
)"
bash scripts/verify-consumer-pom.sh /tmp/repository "${version}" mvn ./mvnw
- run: ./mvnw -B -Prelease -DskipTests deploy
- name: Verify Dependabot security alerts
run: gh api repos/${GITHUB_REPOSITORY}/dependabot/alerts
Expand Down Expand Up @@ -91,6 +101,56 @@ cat >> "${complete_workflow}" <<'YAML'
YAML
assert_accepts "${complete_workflow}"

legacy_version_extraction_workflow="${temp_dir}/legacy-version-extraction-release.yml"
awk '
/ version="\$\(/ {
print " version=\"\$(./mvnw -q help:evaluate -Dexpression=project.version -DforceStdout | tail -n 1)\""
skipping = 1
next
}
skipping && / \)/ {
skipping = 0
next
}
!skipping { print }
' "${complete_workflow}" > "${legacy_version_extraction_workflow}"
assert_rejects "${legacy_version_extraction_workflow}"

partially_legacy_version_extraction_workflow="${temp_dir}/partially-legacy-version-extraction-release.yml"
awk '
/ version="\$\(/ {
version_extraction_count++
if (version_extraction_count == 2) {
print " version=\"\$(./mvnw -q help:evaluate -Dexpression=project.version -DforceStdout | tail -n 1)\""
skipping = 1
next
}
}
skipping && / \)/ {
skipping = 0
next
}
!skipping { print }
' "${complete_workflow}" > "${partially_legacy_version_extraction_workflow}"
assert_rejects "${partially_legacy_version_extraction_workflow}"

missing_consumer_pom_version_extraction_workflow="${temp_dir}/missing-consumer-pom-version-extraction-release.yml"
awk '
/ version="\$\(/ {
version_extraction_count++
if (version_extraction_count == 2) {
skipping = 1
next
}
}
skipping && / \)/ {
skipping = 0
next
}
!skipping { print }
' "${complete_workflow}" > "${missing_consumer_pom_version_extraction_workflow}"
assert_rejects "${missing_consumer_pom_version_extraction_workflow}"

missing_vulnerability_alerts_permission_workflow="${temp_dir}/missing-vulnerability-alerts-permission-release.yml"
grep -v "vulnerability-alerts: read" "${complete_workflow}" > "${missing_vulnerability_alerts_permission_workflow}"
assert_rejects "${missing_vulnerability_alerts_permission_workflow}"
Expand Down
14 changes: 14 additions & 0 deletions scripts/verify-release-workflow.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,18 @@ require_text() {
fi
}

require_count() {
local text="$1"
local expected_count="$2"
local actual_count

actual_count="$(grep -Fc -- "${text}" "${workflow_file}" || true)"
if [[ "${actual_count}" != "${expected_count}" ]]; then
echo "Release workflow must contain ${expected_count} occurrence(s) of: ${text}" >&2
exit 1
fi
}

forbid_text() {
local text="$1"
if grep -Fq -- "${text}" "${workflow_file}"; then
Expand All @@ -32,6 +44,7 @@ require_text "Verify immutable release source"
require_text "Verify complete CI"
require_text 'test "${{ inputs.release_tag }}" = "v${version}"'
require_text 'test -z "$(git status --porcelain)"'
require_count "sed -n 's/^\\[INFO\\] \\[stdout\\] //p'" 2
require_text "gh run view"
require_text "actions: read"
require_text "-Prelease -DskipTests verify"
Expand All @@ -54,5 +67,6 @@ require_text "target/*.asc"
forbid_text "versions-maven-plugin"
forbid_text "versions:set"
forbid_text "git push"
forbid_text "-DforceStdout | tail -n 1"

echo "Release workflow verification passed: ${workflow_file}"
Loading