Fix div by zero error#89
Draft
willirath wants to merge 1 commit into
Draft
Conversation
Author
|
Closes #16. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In floating point arithmetics, we often avoid div by zero errors by rewriting
c = a / btoc = a / (b + eps)with, e.g.,eps = 1.0e-15. This PR suggest a similar fix to avoid div by zero ensuring that the divizor is never zero in https://github.com/willirath/xhistogram/blob/2b6130da9eb35a9fe9f72ec723cfc9971ce228e8/xhistogram/core.py#L115-L117Most of the CI appears to fail which is due to outdated Python versions, I think.