-
Notifications
You must be signed in to change notification settings - Fork 4
ci: show newest binary-size revisions first #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+23
−14
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -257,7 +257,7 @@ function findMeta(key) { | |
|
|
||
| function latestRun() { | ||
| const runs = state.index && state.index.runs || []; | ||
| return runs[runs.length - 1]; | ||
| return runs[0]; | ||
| } | ||
|
|
||
| function measureValue(benchmark, config, measure) { | ||
|
|
@@ -469,7 +469,8 @@ async function renderTables() { | |
|
|
||
| function chartRuns() { | ||
| const limit = Number(dom.historyRange.value); | ||
| return limit > 0 ? state.index.runs.slice(-limit) : state.index.runs.slice(); | ||
| const newest = limit > 0 ? state.index.runs.slice(0, limit) : state.index.runs.slice(); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: the variable is named |
||
| return newest.reverse(); | ||
| } | ||
|
|
||
| function chartBand(documents, metas, benchmarkName, measure, title) { | ||
|
|
@@ -640,7 +641,6 @@ async function main() { | |
| if (!response.ok) throw new Error("Cannot load the run index"); | ||
| state.index = await response.json(); | ||
| if (!state.index.runs || !state.index.runs.length) throw new Error("No benchmark runs are available"); | ||
| state.page = Math.max(1, Math.ceil(state.index.runs.length / state.pageSize)); | ||
| state.benchmarkNames = sortedBenchmarkNames(state.index.benchmarkNames); | ||
| if (!state.benchmarkNames.length) { | ||
| state.benchmarkNames = benchmarkNamesFromDocuments([await loadRun(latestRun())]); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the newest-first result depends on
main_historybeing passed oldest-first (enumerated 1=oldest → N=newest, then sortedreverse=True). That invariant is only documented in the argparse help. A one-line comment here notingmain_historyis expected oldest-first would keep the intent local to where it's consumed.