Skip to content

ci: prevent stale jobs from rolling back Pages #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhouguangyuan0718 merged 1 commit into from
Aug 22, 2026
Merged

ci: prevent stale jobs from rolling back Pages #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/llgo-binary-size-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
- main
paths:
- ci/llgo-size/site/**
- ci/llgo-size/publish.sh
- ci/llgo-performance/publish.sh

@fennoai fennoai Bot Aug 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] Pages trigger lists perf/compat publish.sh it never runs

The Pages workflow adds ci/llgo-performance/publish.sh and ci/llgo-compatibility/publish.sh to its push paths trigger, but the publish-site job only runs prepare-pages-branch.sh and ci/llgo-size/publish-site.sh — never the performance/compatibility publish.sh. Editing only one of those (without touching ci/llgo-size/site/**) will launch a Pages redeploy that re-pushes identical assets. The rationale (all three share the ci/llgo-size/site/ assets, so a change to their copy logic should refresh the site) is reasonable but non-obvious; a one-line comment here would prevent future confusion.

- ci/llgo-compatibility/publish.sh
- ci/llgo-size/publish-site.sh
- ci/llgo-size/enrich_pull_requests.py
- ci/llgo-size/prepare-pages-branch.sh
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/llgo-binary-size.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
- main
paths-ignore:
- ci/llgo-size/site/**
- ci/llgo-size/publish.sh

@fennoai fennoai Bot Aug 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] publish.sh added to push paths-ignore but not pull_request

This PR adds ci/llgo-size/publish.sh to the push paths-ignore (line 9), but the pull_request paths-ignore block (lines 25-38) omits it — even though the sibling publish-site.sh and prepare-pages-branch.sh are ignored in both blocks. Effect: editing only ci/llgo-size/publish.sh skips the binary-size build on main pushes but still triggers the full build on PRs. (The perf/compat publish scripts are covered on both sides via the ci/llgo-performance/** / ci/llgo-compatibility/** globs, so only the size script is asymmetric.) If running the size job on PRs to validate publish logic is intended, consider adding a short comment; otherwise mirror this entry into the pull_request block for consistency.

- ci/llgo-size/publish-site.sh
- ci/llgo-size/prepare-pages-branch.sh
- ci/llgo-performance/**
Expand Down
7 changes: 6 additions & 1 deletion ci/llgo-compatibility/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,13 @@ with open(os.path.join(data_dir, "index.json"), "w", encoding="utf-8") as destin
destination.write("\n")
PY

# Result jobs can finish long after a newer site revision has been published.
# Seed a brand-new Pages branch, but leave existing static assets to the
# dedicated Pages workflow so an old result job cannot roll the UI back.
for file in index.html app.js performance.html performance.js compatibility.html compatibility.js style.css _config.yml; do
cp "$site_dir/$file" "$pages_dir/$file"
if [[ ! -e "$pages_dir/$file" ]]; then
cp "$site_dir/$file" "$pages_dir/$file"
fi
done
rm -f "$pages_dir/.nojekyll"

Expand Down
7 changes: 6 additions & 1 deletion ci/llgo-performance/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,13 @@ with open(os.path.join(data_dir, "index.json"), "w", encoding="utf-8") as destin
destination.write("\n")
PY

# Result jobs can finish long after a newer site revision has been published.
# Seed a brand-new Pages branch, but leave existing static assets to the
# dedicated Pages workflow so an old result job cannot roll the UI back.
for file in index.html app.js performance.html performance.js compatibility.html compatibility.js style.css _config.yml; do
cp "$site_dir/$file" "$pages_dir/$file"
if [[ ! -e "$pages_dir/$file" ]]; then
cp "$site_dir/$file" "$pages_dir/$file"
fi
done
rm -f "$pages_dir/.nojekyll"

Expand Down
7 changes: 6 additions & 1 deletion ci/llgo-size/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,13 @@ for source in sorted(os.listdir(runs_dir)):
continue
os.rename(source_dir, target_dir)
PY
# Result jobs can finish long after a newer site revision has been published.
# Seed a brand-new Pages branch, but leave existing static assets to the
# dedicated Pages workflow so an old result job cannot roll the UI back.
for file in index.html app.js performance.html performance.js compatibility.html compatibility.js style.css _config.yml; do
cp "$site_dir/$file" "$pages_dir/$file"
if [[ ! -e "$pages_dir/$file" ]]; then
cp "$site_dir/$file" "$pages_dir/$file"
fi
done
rm -f "$pages_dir/.nojekyll"

Expand Down
Loading