Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,24 @@ jobs:
LLGO_ROOT: ${{ github.workspace }}
steps:
- uses: actions/checkout@v7
with:
fetch-depth: 0

- name: Determine pull request merge-base
if: github.event_name == 'pull_request'
id: merge-base
run: |
git fetch https://github.com/${{ github.event.pull_request.base.repo.full_name }}.git ${{ github.event.pull_request.base.ref }}
base_sha=$(git merge-base FETCH_HEAD ${{ github.event.pull_request.head.sha }})
echo "sha=$base_sha" >> "$GITHUB_OUTPUT"
echo "Computed pull request merge-base: $base_sha (head: ${{ github.event.pull_request.head.sha }})"

- name: Check out pull request base benchmark source
if: github.event_name == 'pull_request'
uses: actions/checkout@v7
with:
repository: ${{ github.event.pull_request.base.repo.full_name }}
ref: ${{ github.event.pull_request.base.sha }}
ref: ${{ steps.merge-base.outputs.sha }}
path: .benchmark/source
persist-credentials: false

Expand Down
6 changes: 3 additions & 3 deletions benchmark/baseline/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ commit, branch, or pull-request series.

The program workloads reuse:

- `benchmark/binary_size/cprintf`: only `lib/c.Printf`;
- `benchmark/binary_size/println`: only the built-in `println`;
- `benchmark/binary_size/fmtprintf`: `fmt.Printf`.
- `benchmark/binary_size/cprintf`: only `lib/c.Printf` (default and `-lto=full`);
- `benchmark/binary_size/println`: only the built-in `println` (default and `-lto=full`);
- `benchmark/binary_size/fmtprintf`: `fmt.Printf` (default and `-lto=full`).

For each workload, the collector performs an unmeasured warm build, then records
median build time, median process time, file size, executable-code bytes,
Expand Down
10 changes: 8 additions & 2 deletions benchmark/baseline/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,16 @@ type workload struct {
name string
source string
output string
flags []string
}

var workloads = []workload{
{name: "cprintf", source: "benchmark/binary_size/cprintf/main.go", output: "Hello, world\n"},
{name: "cprintf_lto", source: "benchmark/binary_size/cprintf/main.go", output: "Hello, world\n", flags: []string{"-lto=full"}},
{name: "println", source: "benchmark/binary_size/println/main.go", output: "Hello, world\n"},
{name: "println_lto", source: "benchmark/binary_size/println/main.go", output: "Hello, world\n", flags: []string{"-lto=full"}},
{name: "fmtprintf", source: "benchmark/binary_size/fmtprintf/main.go", output: "Hello, world\n"},
{name: "fmtprintf_lto", source: "benchmark/binary_size/fmtprintf/main.go", output: "Hello, world\n", flags: []string{"-lto=full"}},
}

var expectedGoBenchmarks = []string{
Expand Down Expand Up @@ -223,15 +227,17 @@ func collect(ctx context.Context, root, llgo, out string, buildRuns, runRuns int
var sizes, timings []metric
for _, item := range workloads {
binary := filepath.Join(binDir, item.name)
buildArgs := append([]string{"build"}, item.flags...)
buildArgs = append(buildArgs, "-o", binary, filepath.Join(root, item.source))
// Keep first-use toolchain and filesystem caches out of the measured
// median so the first revision is not systematically disadvantaged.
if err := run(ctx, env, io.Discard, llgo, "build", "-o", binary, filepath.Join(root, item.source)); err != nil {
if err := run(ctx, env, io.Discard, llgo, buildArgs...); err != nil {
return fmt.Errorf("warm build %s: %w", item.name, err)
}
buildDurations := make([]time.Duration, 0, buildRuns)
for range buildRuns {
start := time.Now()
if err := run(ctx, env, io.Discard, llgo, "build", "-o", binary, filepath.Join(root, item.source)); err != nil {
if err := run(ctx, env, io.Discard, llgo, buildArgs...); err != nil {
return fmt.Errorf("build %s: %w", item.name, err)
}
buildDurations = append(buildDurations, time.Since(start))
Expand Down
1 change: 1 addition & 0 deletions benchmark/baseline/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ func TestExportBenchmarks(t *testing.T) {
"Unit file-bytes better=lower assume=exact",
"Unit build-ns better=lower",
"BenchmarkProgram/cprintf 1 1 file-bytes 1 text-bytes 1 data-bytes 1 bss-bytes 1 build-ns 1 run-ns",
"BenchmarkProgram/cprintf_lto 1 1 file-bytes 1 text-bytes 1 data-bytes 1 bss-bytes 1 build-ns 1 run-ns",
"BenchmarkRuntimeGetG-1 100 12.5 ns/op",
} {
if !strings.Contains(text, want) {
Expand Down
6 changes: 2 additions & 4 deletions cl/_testgo/equal/in.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ package main
// Arrays: all three elements participate in equality, and inequality negates
// the aggregate result rather than changing element semantics.
// CHECK-LABEL: define void @"main.init#2"(){{.*}} {
// CHECK: %[[ARRAY_L:[0-9]+]] = load [3 x i64], ptr %{{[0-9]+}}
// CHECK: %[[ARRAY_R:[0-9]+]] = load [3 x i64], ptr %{{[0-9]+}}
// CHECK: extractvalue [3 x i64] %[[ARRAY_L]], 0
// CHECK: extractvalue [3 x i64] %[[ARRAY_R]], 0
// CHECK: extractvalue [3 x i64] %[[ARRAY_L:[0-9]+]], 0
// CHECK: extractvalue [3 x i64] %[[ARRAY_R:[0-9]+]], 0
// CHECK: extractvalue [3 x i64] %[[ARRAY_L]], 1
// CHECK: extractvalue [3 x i64] %[[ARRAY_R]], 1
// CHECK: extractvalue [3 x i64] %[[ARRAY_L]], 2
Expand Down
3 changes: 3 additions & 0 deletions cl/_testgo/tptypes/in.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ func main() {
// CHECK-NEXT: call void @"{{.*}}/runtime/internal/runtime.PrintInt"(i64 0)
// CHECK-NEXT: call void @"{{.*}}/runtime/internal/runtime.PrintByte"(i8 10)
// CHECK-NEXT: %[[TMP16:[0-9]+]] = call ptr @"{{.*}}/runtime/internal/runtime.AllocZ"(i64 24)
// CHECK-NEXT: store %"main.Slice{{\[\[}}]int,int]" zeroinitializer, ptr %[[TMP16]], align 8
// CHECK-NEXT: %[[TMP17:[0-9]+]] = call ptr @"{{.*}}/runtime/internal/runtime.AllocZ"(i64 8)
// CHECK-NEXT: %[[TMP18:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP17]], i64 0
// CHECK-NEXT: store i64 100, ptr %[[TMP18]], align 8
Expand All @@ -116,6 +117,7 @@ func main() {
// CHECK-NEXT: %[[TMP21:[0-9]+]] = insertvalue %"{{.*}}/runtime/internal/runtime.Slice" %[[TMP20]], i64 1, 2
// CHECK-NEXT: %[[TMP22:[0-9]+]] = call %"{{.*}}/runtime/internal/runtime.Slice" @"main.(*Slice{{\[\[}}]int,int]).Append"(ptr %[[TMP16]], %"{{.*}}/runtime/internal/runtime.Slice" %[[TMP21]])
// CHECK-NEXT: %[[TMP23:[0-9]+]] = call ptr @"{{.*}}/runtime/internal/runtime.AllocZ"(i64 24)
// CHECK-NEXT: store %"main.Slice{{\[\[}}]string,string]" zeroinitializer, ptr %[[TMP23]], align 8
// CHECK-NEXT: %[[TMP24:[0-9]+]] = call ptr @"{{.*}}/runtime/internal/runtime.AllocZ"(i64 16)
// CHECK-NEXT: %[[TMP25:[0-9]+]] = getelementptr inbounds %"{{.*}}/runtime/internal/runtime.String", ptr %[[TMP24]], i64 0
// CHECK-NEXT: store %"{{.*}}/runtime/internal/runtime.String" { ptr @[[GLOB0]], i64 5 }, ptr %[[TMP25]], align 8
Expand All @@ -124,6 +126,7 @@ func main() {
// CHECK-NEXT: %[[TMP28:[0-9]+]] = insertvalue %"{{.*}}/runtime/internal/runtime.Slice" %[[TMP27]], i64 1, 2
// CHECK-NEXT: %[[TMP29:[0-9]+]] = call %"{{.*}}/runtime/internal/runtime.Slice" @"main.(*Slice{{\[\[}}]string,string]).Append"(ptr %[[TMP23]], %"{{.*}}/runtime/internal/runtime.Slice" %[[TMP28]])
// CHECK-NEXT: %[[TMP30:[0-9]+]] = call ptr @"{{.*}}/runtime/internal/runtime.AllocZ"(i64 24)
// CHECK-NEXT: store %"main.Slice{{\[\[}}]int,int]" zeroinitializer, ptr %[[TMP30]], align 8
// CHECK-NEXT: %[[TMP31:[0-9]+]] = call ptr @"{{.*}}/runtime/internal/runtime.AllocZ"(i64 32)
// CHECK-NEXT: %[[TMP32:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP31]], i64 0
// CHECK-NEXT: store i64 1, ptr %[[TMP32]], align 8
Expand Down
9 changes: 7 additions & 2 deletions cl/_testrt/gblarray/in.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,13 @@ func main() {
// CHECK-NEXT: _llgo_[[BB1]]:
// CHECK-NEXT: store i1 true, ptr @"main.init$guard", align 1
// CHECK-NEXT: call void @"{{.*}}/runtime/abi.init"()
// CHECK-NEXT: %[[TMP1:[0-9]+]] = call ptr @main.basicType(i64 24)
// CHECK-NEXT: store ptr %[[TMP1]], ptr getelementptr inbounds (ptr, ptr @main.basicTypes, i64 24), align 8
// CHECK-NEXT: %[[TMP1:[0-9]+]] = alloca [25 x ptr], align 8
// CHECK-NEXT: call void @llvm.memset.p0.i64(ptr %[[TMP1]], i8 0, i64 200, i1 false)
// CHECK-NEXT: %[[TMP2:[0-9]+]] = getelementptr inbounds ptr, ptr %[[TMP1]], i64 24
// CHECK-NEXT: %[[TMP3:[0-9]+]] = call ptr @main.basicType(i64 24)
// CHECK-NEXT: store ptr %[[TMP3]], ptr %[[TMP2]], align 8
// CHECK-NEXT: %[[TMP4:[0-9]+]] = load [25 x ptr], ptr %[[TMP1]], align 8
// CHECK-NEXT: store [25 x ptr] %[[TMP4]], ptr @main.basicTypes, align 8
// CHECK-NEXT: br label %_llgo_[[BB2]]
// CHECK-EMPTY:
// CHECK-NEXT: _llgo_[[BB2]]:
Expand Down
17 changes: 3 additions & 14 deletions cl/_testrt/index/in.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,7 @@ type S []int
// that selected value are consumed.
// CHECK: %[[POINT:[0-9]+]] = alloca %main.point
// CHECK: %[[POINTS:[0-9]+]] = alloca [3 x %main.point]
// CHECK: %[[POINT2_INIT:[0-9]+]] = getelementptr inbounds %main.point, ptr %[[POINTS]], i64 2
// CHECK: %[[POINT2_X:[0-9]+]] = getelementptr inbounds %main.point, ptr %[[POINT2_INIT]], i32 0, i32 0
// CHECK: %[[POINT2_Y:[0-9]+]] = getelementptr inbounds %main.point, ptr %[[POINT2_INIT]], i32 0, i32 1
// CHECK: store i64 5, ptr %[[POINT2_X]]
// CHECK: store i64 6, ptr %[[POINT2_Y]]
// CHECK: load [3 x %main.point], ptr %[[POINTS]]
// CHECK: %[[POINT2:[0-9]+]] = getelementptr inbounds %main.point, ptr %[[POINTS]], i64 2
// CHECK: %[[SELECTED_POINT:[0-9]+]] = load %main.point, ptr %[[POINT2]]
// CHECK: store %main.point %[[SELECTED_POINT]], ptr %[[POINT]]
Expand All @@ -31,13 +27,7 @@ type S []int
// Nested arrays select row 1 before indexing its two elements.
// CHECK: %[[ROW:[0-9]+]] = alloca [2 x i64]
// CHECK: %[[MATRIX:[0-9]+]] = alloca [2 x [2 x i64]]
// CHECK: %[[ROW1_INIT:[0-9]+]] = getelementptr inbounds [2 x i64], ptr %[[MATRIX]], i64 1
// CHECK: call void @"{{.*}}/runtime/internal/runtime.AssertNilDeref"
// CHECK: %[[ROW1_ELEM0:[0-9]+]] = getelementptr inbounds i64, ptr %[[ROW1_INIT]], i64 0
// CHECK: call void @"{{.*}}/runtime/internal/runtime.AssertNilDeref"
// CHECK: %[[ROW1_ELEM1:[0-9]+]] = getelementptr inbounds i64, ptr %[[ROW1_INIT]], i64 1
// CHECK: store i64 3, ptr %[[ROW1_ELEM0]]
// CHECK: store i64 4, ptr %[[ROW1_ELEM1]]
// CHECK: load [2 x [2 x i64]], ptr %[[MATRIX]]
// CHECK: %[[ROW1:[0-9]+]] = getelementptr inbounds [2 x i64], ptr %[[MATRIX]], i64 1
// CHECK: %[[SELECTED_ROW:[0-9]+]] = load [2 x i64], ptr %[[ROW1]]
// CHECK: store [2 x i64] %[[SELECTED_ROW]], ptr %[[ROW]]
Expand All @@ -64,8 +54,7 @@ type S []int
// Named pointer-to-array indexing and named-slice indexing use different
// lowering. The slice predicate, length and data pointer must stay associated.
// CHECK: %[[NAMED_ARRAY:[0-9]+]] = call ptr @"{{.*}}/runtime/internal/runtime.AllocZ"(i64 16)
// CHECK: %[[NAMED_ELEM_INIT:[0-9]+]] = getelementptr inbounds i64, ptr %[[NAMED_ARRAY]], i64 1
// CHECK: store i64 2, ptr %[[NAMED_ELEM_INIT]]
// CHECK: store [2 x i64] %{{[0-9]+}}, ptr %[[NAMED_ARRAY]]
// CHECK: %[[NAMED_ELEM:[0-9]+]] = getelementptr inbounds i64, ptr %[[NAMED_ARRAY]], i64 1
// CHECK: load i64, ptr %[[NAMED_ELEM]]
// CHECK: %[[SLICE_DATA_RAW:[0-9]+]] = call ptr @"{{.*}}/runtime/internal/runtime.AllocZ"(i64 32)
Expand Down
54 changes: 29 additions & 25 deletions cl/_testrt/qsort/in.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,44 +26,48 @@ func main() {
// CHECK-LABEL: define void @main.main(){{.*}} {
// CHECK-NEXT: _llgo_[[BB0:[0-9]+]]:
// CHECK-NEXT: %[[TMP0:[0-9]+]] = call ptr @"{{.*}}/runtime/internal/runtime.AllocZ"(i64 40)
// CHECK-NEXT: %[[TMP1:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP0]], i64 0
// CHECK-NEXT: %[[TMP2:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP0]], i64 1
// CHECK-NEXT: %[[TMP3:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP0]], i64 2
// CHECK-NEXT: %[[TMP4:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP0]], i64 3
// CHECK-NEXT: %[[TMP5:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP0]], i64 4
// CHECK-NEXT: store i64 100, ptr %[[TMP1]], align 8
// CHECK-NEXT: store i64 8, ptr %[[TMP2]], align 8
// CHECK-NEXT: store i64 23, ptr %[[TMP3]], align 8
// CHECK-NEXT: store i64 2, ptr %[[TMP4]], align 8
// CHECK-NEXT: store i64 7, ptr %[[TMP5]], align 8
// CHECK-NEXT: %[[TMP6:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP0]], i64 0
// CHECK-NEXT: call void @qsort(ptr %[[TMP6]], i64 5, i64 8, ptr @"main.main$1")
// CHECK-NEXT: %[[TMP7:[0-9]+]] = load [5 x i64], ptr %[[TMP0]], align 8
// CHECK-NEXT: %[[TMP1:[0-9]+]] = alloca [5 x i64], align 8
// CHECK-NEXT: call void @llvm.memset.p0.i64(ptr %[[TMP1]], i8 0, i64 40, i1 false)
// CHECK-NEXT: %[[TMP2:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP1]], i64 0
// CHECK-NEXT: %[[TMP3:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP1]], i64 1
// CHECK-NEXT: %[[TMP4:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP1]], i64 2
// CHECK-NEXT: %[[TMP5:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP1]], i64 3
// CHECK-NEXT: %[[TMP6:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP1]], i64 4
// CHECK-NEXT: store i64 100, ptr %[[TMP2]], align 8
// CHECK-NEXT: store i64 8, ptr %[[TMP3]], align 8
// CHECK-NEXT: store i64 23, ptr %[[TMP4]], align 8
// CHECK-NEXT: store i64 2, ptr %[[TMP5]], align 8
// CHECK-NEXT: store i64 7, ptr %[[TMP6]], align 8
// CHECK-NEXT: %[[TMP7:[0-9]+]] = load [5 x i64], ptr %[[TMP1]], align 8
// CHECK-NEXT: store [5 x i64] %[[TMP7]], ptr %[[TMP0]], align 8
// CHECK-NEXT: %[[TMP8:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP0]], i64 0
// CHECK-NEXT: call void @qsort(ptr %[[TMP8]], i64 5, i64 8, ptr @"main.main$1")
// CHECK-NEXT: %[[TMP9:[0-9]+]] = load [5 x i64], ptr %[[TMP0]], align 8
// CHECK-NEXT: br label %_llgo_[[BB1:[0-9]+]]
// CHECK-EMPTY:
// CHECK-NEXT: _llgo_[[BB1]]:
// CHECK-NEXT: %[[TMP8:[0-9]+]] = phi i64 [ -1, %_llgo_[[BB0]] ], [ %[[TMP9:[0-9]+]], %_llgo_[[BB5:[0-9]+]] ]
// CHECK-NEXT: %[[TMP9]] = add i64 %[[TMP8]], 1
// CHECK-NEXT: %[[TMP10:[0-9]+]] = icmp slt i64 %[[TMP9]], 5
// CHECK-NEXT: br i1 %[[TMP10]], label %_llgo_[[BB2:[0-9]+]], label %_llgo_[[BB3:[0-9]+]]
// CHECK-NEXT: %[[TMP10:[0-9]+]] = phi i64 [ -1, %_llgo_[[BB0]] ], [ %[[TMP11:[0-9]+]], %_llgo_[[BB5:[0-9]+]] ]
// CHECK-NEXT: %[[TMP11]] = add i64 %[[TMP10]], 1
// CHECK-NEXT: %[[TMP12:[0-9]+]] = icmp slt i64 %[[TMP11]], 5
// CHECK-NEXT: br i1 %[[TMP12]], label %_llgo_[[BB2:[0-9]+]], label %_llgo_[[BB3:[0-9]+]]
// CHECK-EMPTY:
// CHECK-NEXT: _llgo_[[BB2]]:
// CHECK-NEXT: %[[TMP11:[0-9]+]] = icmp slt i64 %[[TMP9]], 0
// CHECK-NEXT: %[[TMP12:[0-9]+]] = icmp uge i64 %[[TMP9]], 5
// CHECK-NEXT: %[[TMP13:[0-9]+]] = or i1 %[[TMP12]], %[[TMP11]]
// CHECK-NEXT: br i1 %[[TMP13]], label %_llgo_[[BB4:[0-9]+]], label %_llgo_[[BB5]]
// CHECK-NEXT: %[[TMP13:[0-9]+]] = icmp slt i64 %[[TMP11]], 0
// CHECK-NEXT: %[[TMP14:[0-9]+]] = icmp uge i64 %[[TMP11]], 5
// CHECK-NEXT: %[[TMP15:[0-9]+]] = or i1 %[[TMP14]], %[[TMP13]]
// CHECK-NEXT: br i1 %[[TMP15]], label %_llgo_[[BB4:[0-9]+]], label %_llgo_[[BB5]]
// CHECK-EMPTY:
// CHECK-NEXT: _llgo_[[BB3]]:
// CHECK-NEXT: ret void
// CHECK-EMPTY:
// CHECK-NEXT: _llgo_[[BB4]]:
// CHECK-NEXT: call void @"{{.*}}/runtime/internal/runtime.PanicIndex"(i64 %[[TMP9]], i64 5)
// CHECK-NEXT: call void @"{{.*}}/runtime/internal/runtime.PanicIndex"(i64 %[[TMP11]], i64 5)
// CHECK-NEXT: br label %_llgo_[[BB4]]
// CHECK-EMPTY:
// CHECK-NEXT: _llgo_[[BB5]]:
// CHECK-NEXT: %[[TMP14:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP0]], i64 %[[TMP9]]
// CHECK-NEXT: %[[TMP15:[0-9]+]] = load i64, ptr %[[TMP14]], align 8
// CHECK-NEXT: %[[TMP16:[0-9]+]] = call i32 (ptr, ...) @printf(ptr @[[GLOB0]], i64 %[[TMP15]])
// CHECK-NEXT: %[[TMP16:[0-9]+]] = getelementptr inbounds i64, ptr %[[TMP0]], i64 %[[TMP11]]
// CHECK-NEXT: %[[TMP17:[0-9]+]] = load i64, ptr %[[TMP16]], align 8
// CHECK-NEXT: %[[TMP18:[0-9]+]] = call i32 (ptr, ...) @printf(ptr @[[GLOB0]], i64 %[[TMP17]])
// CHECK-NEXT: br label %_llgo_[[BB1]]
// CHECK-NEXT: }

Expand Down
Loading
Loading