add config options#19
Draft
michel-ZH wants to merge 4 commits into
Draft
Conversation
added 2 commits
December 30, 2025 04:57
michel-ZH
marked this pull request as draft
December 30, 2025 01:33
xhebox
reviewed
Dec 30, 2025
Comment on lines
+275
to
+277
| PangoFontDescription *desc = pango_font_description_from_string(POPUP_FONT); | ||
| pango_layout_set_font_description(state->popup_pango_layout, desc); | ||
| pango_font_description_free(desc); |
Owner
There was a problem hiding this comment.
Setting font description does not need fontmap, just keep the old way of creating pango_ctx
| double width, | ||
| double height, | ||
| double radius) { | ||
| double x, |
Owner
There was a problem hiding this comment.
I am using softtabs with two or four. and will format using clangd. maybe add your editor config file?
added 2 commits
December 30, 2025 09:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved config.c's im_toggle to im.c and made the toggle key user-configurable in a new config.h file. I've also added a boolean check if user prefers single press / double press of the toggle key to toggle the im.
I also made the pop-up-'s colours and font likewise configurable in that file.
Are those changes desirabel?