fix(deps): bump rustls to 0.23.45 for RUSTSEC-2026-0285 - #1412
Merged
Merged
Conversation
RUSTSEC-2026-0285 (TLS 1.3 handshake messages incorrectly accepted across encryption level boundaries) affects rustls 0.23.41, which src-tauri/Cargo.lock pinned. The rust-audit job fails on it, and rust-audit feeds the required rust check, so every open PR was blocked. A plain cargo update -p rustls stops at 0.23.43, still vulnerable, because 0.23.44 and later need newer aws-lc-rs and rustls-webpki. So the update is pinned to the patched release, which moves: rustls 0.23.41 -> 0.23.45 rustls-webpki 0.103.13 -> 0.103.15 aws-lc-rs 1.17.0 -> 1.18.1 aws-lc-sys 0.41.0 -> 0.45.0 rustls reaches the app through reqwest, hyper-rustls, rustls-platform-verifier and tauri-plugin-updater. Lockfile only; no manifest changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustls0.23.41, the versionsrc-tauri/Cargo.lockpinned. The fix is 0.23.45 or later.rust-auditfails on it. It feeds the requiredrustcheck, so every open PR is blocked, including fix: run both mutation tools in place so their baselines see the real tree (fixes #1409) #1410 and fix: keep shell scripts on LF line endings on every checkout #1411.What Changed
A plain
cargo update -p rustlsstops at 0.23.43, which is still vulnerable, because 0.23.44 and later need neweraws-lc-rsandrustls-webpki. The update is pinned to the patched release (--precise 0.23.45), which moves:rustlsrustls-webpkiaws-lc-rsaws-lc-sysrustlsreaches the app throughreqwest,hyper-rustls,rustls-platform-verifierandtauri-plugin-updater.Validation
cargo auditwith CI's exact flags: exit 1 onmain(RUSTSEC-2026-0285), exit 0 with this change. Only the already-allowed "unmaintained" warnings remain.cargo clippy --all-targets -- -D warnings: exit 0.cargo test: exit 0 (3,117 lib tests, plus the integration binaries).bash scripts/check-cross-target.sh:x86_64-pc-windows-gnucompiles clean. This matters becauseaws-lc-sysbuilds C code per target.lint:tauri-versions, the only frontend gate that readsCargo.lock: exit 0.pnpm check:allwas not run: it never invokes cargo, and no other frontend gate reads the lockfile.Type of Change