Skip to content

fix(feedback): await asynchronous knowledge gap persistence - #63

Closed
BigDataDZ wants to merge 9 commits into
xiaour:mainfrom
BigDataDZ:codex/oct24-feedback-growth-await
Closed

BigDataDZ wants to merge 9 commits into
xiaour:mainfrom
BigDataDZ:codex/oct24-feedback-growth-await

Conversation

@BigDataDZ

@BigDataDZ BigDataDZ commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

本PR的原始功能修复已进入最新main87c2966:原始修复提交已通过git merge-base --is-ancestor验证,相关核心文件及回归测试已核对。后续MCP运行时调整保留了配置缓存及Origin校验。当前PR头多出的上游同步/基线冲突处理不构成尚未合入的独立功能,因此关闭,避免重复审阅;分支与提交保留。


原始说明:
Negative feedback on an async platform store returned before GrowthService.record() completed. Growth persistence failures escaped the request instead of following the existing synchronous error semantics. Await the growth record before resolving submitAsync. Positive feedback still bypasses growth. Feedback is saved first, as before: a later growth failure propagates without promising rollback of the feedback row. Move the existing submission routines into feedbackSubmission.js while preserving FeedbackService methods and payloads; the facade shrinks from 108 to 45 lines, below its 76-line baseline. Two regressions failed before the fix. Tests use actual SQLite persistence through an async-only adapter and the real GrowthService, gate the gap write to prove completion ordering, propagate the driver's original error and verify successful gap visibility/positive bypass. Focused 4/4; full suite 737 passed, 15 skipped, 0 failed; eval fixtures 14/14 (two judge results pending). Independent review approved. Architecture errors reduced 34 to 33; no upward baselines. Includes validated prerequisites through #62. Native MySQL persistence acceptance, PostgreSQL/browser acceptance and both Docker configurations passed in CI. The online unit step passed; the job remains red at the existing architecture guard and the online eval step is skipped. Combined with #64: 740 passed, 15 skipped, 0 failed; architecture errors reduced to 32. 本次邮件/审阅反馈核查后的更新:已合入当前main e19d784,解决上游合并#49–#54后产生的config/size-baseline.json冲突。冲突处理逐项取较低值,未提高任何已有基线;业务代码由Git自动合入。 当前head:56f747116cd89a0b888d4b2d61ef137454b743e0。本地定向验证:ℹ tests 44; ℹ pass 42; ℹ fail 0; ℹ skipped 2。跳过项未计为通过。远端CI已重新触发,结果以最新Checks为准,规模门禁尚未宣称全绿。 已再次对齐新发布的main5385ed3(V1.2.0/#76)。逐项保留较低基线,并修复上游基线JSON漏逗号(独立修复#77);未提高已有数值。当前head:50338528f171ed16917d9f8a831e0ddd0c4b36b3。本地定向验证:ℹ tests 27; ℹ pass 26; ℹ fail 0; ℹ skipped 1。跳过项未计为通过。 新主分支全量诊断本身有5个失败;此前零失败结果不再代表当前上游。完整CI以最新Checks为准,未宣称全绿。

BigDataDZ added a commit to BigDataDZ/yolo-data that referenced this pull request Oct 26, 2026
BigDataDZ added a commit to BigDataDZ/yolo-data that referenced this pull request Oct 26, 2026
@BigDataDZ BigDataDZ closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant