Skip to content

web(823): suggest matching team skill as ghost hint while typing - #834

Merged
xiechimon merged 2 commits into
mainfrom
hp/pacman/t-0158-823-skill
Oct 4, 2026
Merged

xiechimon merged 2 commits into
mainfrom
hp/pacman/t-0158-823-skill

Conversation

@xiechimon

Copy link
Copy Markdown
Owner

What

Typing plain prose (e.g. "明早 9 点提醒我") that hits the first-batch trigger table now surfaces a ghost hint bar naming the matching team skill. Tab (or click) accepts the skill token at the caret with the prose untouched; Esc (or the close button) single-ignores that suggestion until the draft is sent.

Decisions locked in the ticket

  • Trigger table ships first-batch only: reminder / translate / summarize / review, in that priority order.
  • Candidate pool is the existing useSkills vocab (same projection as the mention picker and the / menu) — no side table. A team without a matching skill gets no suggestion.
  • False-positive control: single-ignore picked (Esc / close, per suggestion until send). The global switch is deferred.
  • No key clash with / and @: the strip renders only while both menus are closed, and Tab/Enter/Esc keep their menu meaning whenever either menu is open.

Evidence

hint strip while typing
draft after Tab accept
full input-to-accept flow

Checks

  • pnpm lint green, pnpm typecheck green (all packages)
  • unit: skill-suggest 11/11, shared suite 234/234, i18n coverage/scan green
  • e2e: new composer-skill-suggest.spec 6/6 on an isolated port; e2e:affected 756 passed

Typing plain prose that hits the first-batch trigger table (reminder,
translate, summarize, review) shows a ghost hint bar sourced from the
existing useSkills vocab; Tab accepts the skill token at the caret,
Esc/close single-ignores it, and the strip never co-opens with the /
or @ menus.

closes #823
…skill

# Conflicts:
#	apps/web/src/detail/composer.tsx
@xiechimon
xiechimon merged commit fa41f38 into main Oct 4, 2026
8 checks passed
xiechimon added a commit that referenced this pull request Oct 4, 2026
…ing (#834)" (#838)

Reverts fa41f38: merged without user review of the new input behavior. Re-land after review.
@xiechimon
xiechimon deleted the hp/pacman/t-0158-823-skill branch October 4, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant