Repository navigation
chore(840): sync project-new-form probe expectations to spot tokens - #842
Merged
Merged
Conversation
The drive-project-new-form probe still expected the pre-theme-flip indigo focus edge while the form renders the spot-system --focus-ring. Point FOCUS_RING at dark rgb(203,166,247) and, as same-cause residue from #839, DANGER at dark destructive rgb(224,90,90); sync the feature map entries and rename the focus screenshot to 03-focus-ring-spot. closes #840
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(840): sync project-new-form probe expectations to spot tokens
Follow-up to #839:
drive-project-new-form.mjsstill expected thepre-theme-flip indigo focus edge (
--indigo-500), while the formrenders the spot-system
--focus-ring. This syncs the probe to thespot values and updates the feature map to match.
Same-cause extra, found by the verification run: the probe's
DANGERconstant (
#ca3a32) also went stale when #839 moved review/dangertokens onto
--destructive(dark#e05a5a). Fixed in the same filerather than leaving the probe red.
Changes
FOCUS_RING = 'rgb(203, 166, 247)'(dark--focus-ring#cba6f7),DANGER = 'rgb(224, 90, 90)'(dark--destructive#e05a5a)03-focus-ring-indigo.png→03-focus-ring-spot.png; header comments syncedfeatures/project-new-form.md+features/README.mddescribe thespot-system expectation
Verification
drive-project-new-form.mjson an isolated stack(server :8792 + web :5274, fresh DB): 19/19 PASS (
result.jsonin
docs/verify/840/). Run history: round 1 was 18/19 with thefocus check already green and the old
DANGERred (the extra fixedabove); round 3 is a clean relaunch, archived here.
project-new-repo.spec.ts: 16/16 PASS (includesthe focus-ring brand assertion).
Evidence
result.json/responses.json:docs/verify/840/(run notes in
docs/verify/840/README.md).