web(841): wire slash completion into chief drawer composer - #845
Merged
Merged
Conversation
The drawer composer had zero completion wiring, so `/clear` went out as plain text and opened a chief round instead of clearing the input. It now consumes the same #731 registry through the shared useComposerWire face as the detail composer: `/` menu with clear/attach/mention/help plus team skills, review/stop conditionally hidden (no drawer handles, rule 47). Execute-visible feedback: `clear` was the only builtin with no surface of its own, so runBuiltin now toasts a light confirmation through sonner. Tests: new chief-drawer-slash.spec.ts (6), affected surface 773 green, vitest i18n-coverage + completion 38 green, biome + web typecheck clean. Evidence: docs/verify/841 (GIF of the full drawer /clear flow). closes #841
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the #731 slash registry into the chief drawer composer, which had zero completion wiring:
/clearwent out as plain text and opened a chief round instead of clearing the input.What changes
useComposerWireslash face as the detail composer (menu + accept semantics + skills). No review/stop handles exist on this face, so both rows stay hidden per rule 47.clearsemantics match detail: empty the input. It was the only builtin with no visible落点, sorunBuiltinnow confirms through the shared sonner toaster (已清空,en: Cleared).chief-drawer-slash.spec.ts(6 tests): menu contents + conditional hiding,/clearruns with zero chief POSTs and a visible toast, Tab/no-highlight Enter behavior, mid-prompt literal,/helppanel, Esc ladder.Verification
composer-slash/chief-composer-tools/composer-inline-mention47/47, affected surface 773/773 (/tmp/841-affected.logon the lane).vitest run test/i18n-coverage.test.ts test/completion.test.ts38/38; biome + web typecheck clean.Evidence