Fix two-pass encoding and create basic CLI tests#2209
Merged
shssoichiro merged 2 commits intoxiph:masterfrom Mar 24, 2020
Merged
Fix two-pass encoding and create basic CLI tests#2209shssoichiro merged 2 commits intoxiph:masterfrom
shssoichiro merged 2 commits intoxiph:masterfrom
Conversation
shssoichiro
force-pushed
the
fix-two-pass
branch
2 times, most recently
from
6210c17 to
8bf02ab
Compare
lu-zero
approved these changes
Mar 23, 2020
Collaborator
lu-zero
left a comment
lu-zero
left a comment
There was a problem hiding this comment.
Seems fine. Thank you for preparing the test.
rzumer
reviewed
Mar 23, 2020
| fn get_tempfile_path(extension: &str) -> PathBuf { | ||
| let mut path = temp_dir(); | ||
| let filename = | ||
| thread_rng().sample_iter(&Alphanumeric).take(12).collect::<String>(); |
Collaborator
There was a problem hiding this comment.
Might be personal preference, but I think tests should avoid using random values. A second opinion would be nice.
Collaborator
There was a problem hiding this comment.
We could use non-random filenames, since the directory is already temporary
shssoichiro
force-pushed
the
fix-two-pass
branch
from
8bf02ab to
be785d7
Compare
lu-zero
reviewed
Mar 23, 2020
| data | ||
| } | ||
|
|
||
| fn get_tempfile_path(extension: &str) -> PathBuf { |
Collaborator
Author
There was a problem hiding this comment.
I looked into that, but tempfile doesn't have an option to just generate a filename--it also creates the file. For this, we just want a filename in the temp directory that rav1e can write to.
shssoichiro
force-pushed
the
fix-two-pass
branch
3 times, most recently
from
81576ec to
11dfffb
Compare
lu-zero
reviewed
Mar 24, 2020
This reverts commit 45ef0af.
shssoichiro
force-pushed
the
fix-two-pass
branch
from
11dfffb to
c7175d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2208