Skip to content

Replace the unicode toggle with Redmine's sprite icon #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mboremski merged 2 commits into from
Aug 27, 2026
Merged

Replace the unicode toggle with Redmine's sprite icon #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02e8746
Replace the unicode toggle with Redmine's sprite icon
mboremski Aug 26, 2026
5352450
Merge branch 'xmera-circle:master' into feature/change-toggle
mboremski Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/views/workloads/_trigger.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
# Parameters:
# trigger_for: set as "data-for"-attribute
#
# ▶ is a right-pointing filled triangle.
# The icon is rendered once as 'angle-right'. The opened state is expressed by
# the 'opened' css class, which rotates it by 90 degrees. Do not swap the icon
# in JavaScript; the class is the single source of truth for the state.
%>

<span class="trigger closed" data-for="<%= trigger_for %>">&#x25b6;</span>
<span class="trigger closed" data-for="<%= trigger_for %>"><%= sprite_icon('angle-right') %></span>
6 changes: 1 addition & 5 deletions assets/javascripts/slides.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

$(document).ready(function() {
$('.trigger').click(function() {
var OPENED = '&#x25bc;'
var CLOSED = '&#x25b6;'
$(this).toggleClass('closed opened');

identifier = $(this).attr('data-for');
Expand Down Expand Up @@ -44,7 +42,6 @@ $(document).ready(function() {
$(this).show(); // but keep its 'children' closed if any
$(this).siblings('.invisible-issues-summary.' + identifierClasses).show();
});
$(this).html(OPENED);
}
else {
lowerHierarchieLevelClasses = bottomUpHierarchieChain.get(currentHierarchieLevel);
Expand All @@ -54,11 +51,10 @@ $(document).ready(function() {
$(css).hide();
$(css).siblings('.invisible-issues-summary.' + identifierClasses).hide();
currentHierarchieLevel = $(css).find('span.trigger.opened');
currentHierarchieLevel.html(CLOSED);
currentHierarchieLevel.removeClass('opened').addClass('closed');
currentHierarchieLevel.siblings('dl').hide();
})
$(this).siblings().hide();
$(this).html(CLOSED);
}
});
});
9 changes: 9 additions & 0 deletions assets/stylesheets/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,15 @@
margin-right: 4px;
}

.controller-workloads .data .trigger svg {
vertical-align: middle;
transition: transform 0.15s ease-in-out;
}

.controller-workloads .data .trigger.opened svg {
transform: rotate(90deg);
}

.controller-workloads table dt.mt-5,
.controller-workloads table dd.mt-5 {
margin-top: 5px;
Expand Down
Loading