Rename camelCase methods, parameters and variables to snake_case - #49
Merged
Merged
Conversation
Fixes xmera-circle#4 * `sanitizeDateParameter` -> `sanitize_date_parameter` (WorkloadsController) * `clearCache` -> `clear_cache` (WlUserVacation, WlNationalHoliday) * `usersToShow`/`selectedUsers`/`groupsToShow`/`selectedGroups` -> snake_case (WorkloadFiltersHelper) All of them are internal: the two model methods are private callbacks, the controller method is private, and the helper is called positionally from `_filters.erb`. No public API changes. The three `Naming/*` entries are removed from .rubocop_todo.yml. Note that `Naming/MethodParameterName` is a minimum-length cop, not a style cop -- its four recorded offences do not match the current parameter names and look stale. Rubocop is in no Gemfile and does not run in CI, so this could not be verified here; if it still fires, `rubocop --auto-gen-config` regenerates the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
sanitizeDateParameter->sanitize_date_parameter(WorkloadsController)clearCache->clear_cache(WlUserVacation, WlNationalHoliday)usersToShow/selectedUsers/groupsToShow/selectedGroups-> snake_case (WorkloadFiltersHelper)All of them are internal: the two model methods are private callbacks, the controller method is private, and the helper is called positionally from
_filters.erb. No public API changes.The three
Naming/*entries are removed from .rubocop_todo.yml. Note thatNaming/MethodParameterNameis a minimum-length cop, not a style cop -- its four recorded offences do not match the current parameter names and look stale. Rubocop is in no Gemfile and does not run in CI, so this could not be verified here; if it still fires,rubocop --auto-gen-configregenerates the file.