Skip to content

fix(node-sdk): deflake should stream preferences test #3833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
insipx wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(node-sdk): deflake should stream preferences test #3833

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bb592c
fix(node-sdk): deflake `should stream preferences` test
insipx Jul 9, 2026
79c4197
Merge branch 'main' into fix/issue-3831
insipx Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions sdks/js/node-sdk/test/Preferences.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,14 +246,25 @@ describe("Preferences", () => {
await client2.conversations.syncAll();
await sleep(1000);

setTimeout(() => {
const preferences: UserPreferenceUpdate[] = [];

// Safety net: end the stream if the expected updates never arrive, so the
// assertion below fails clearly instead of the test hanging until timeout.
// The HmacKeyUpdate events depend on network propagation, so we collect
// until we have all 4 expected updates rather than ending on a fixed timer.
const endTimeout = setTimeout(() => {
void stream.end();
}, 100);
}, 10000);

const preferences: UserPreferenceUpdate[] = [];
for await (const update of stream) {
preferences.push(...update);
if (preferences.length >= 4) {
break;
}
}
clearTimeout(endTimeout);
await stream.end();

expect(preferences.length).toBe(4);
const consentUpdate1 = preferences[0] as Extract<
UserPreferenceUpdate,
Expand Down
Loading