Skip to content

feat(mls/api): XIP-83 Subscribe — tag deliveries with wave mutate_id and enforce ordering guarantees #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tylerhawkes merged 1 commit into from
Jul 10, 2026
Merged

feat(mls/api): XIP-83 Subscribe — tag deliveries with wave mutate_id and enforce ordering guarantees #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/mls/api/v1/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,14 @@ type Service struct {
cutoverChecker *migration.CutoverChecker

// Subscribe (XIP-83) tunables; overridable in tests. Default to the package consts
// (subscribePingInterval / subscribePongDeadline / maxPendingBytes / maxFrameBytes).
// (subscribePingInterval / subscribePongDeadline / maxPendingBytes / maxFrameBytes /
// catchUpScanPageLimit / maxMutateAdds).
pingInterval time.Duration
pongDeadline time.Duration
maxPendingBytes int
maxFrameBytes int
scanPageLimit int32
maxMutateAdds int
}

func NewService(
Expand All @@ -83,6 +86,8 @@ func NewService(
pongDeadline: subscribePongDeadline,
maxPendingBytes: maxPendingBytes,
maxFrameBytes: maxFrameBytes,
scanPageLimit: catchUpScanPageLimit,
maxMutateAdds: maxMutateAdds,
}
s.ctx, s.ctxCancel = context.WithCancel(context.Background())
if s.dbWorker, err = newDBWorker(s.ctx, log, s.readOnlyStore.Queries(), subDispatcher, DEFAULT_POLL_INTERVAL); err != nil {
Expand Down
586 changes: 308 additions & 278 deletions pkg/mls/api/v1/subscribe.go
View file
Open in desktop
Comment thread
tylerhawkes marked this conversation as resolved.

Large diffs are not rendered by default.

Loading
Loading