support unseekable streams: skip encoding detection - #7
Merged
Merged
Conversation
xoofx
force-pushed
the
support-unseekable-streams
branch
from
March 12, 2026 18:53
8c54095 to
8b6adfb
Compare
DetectEncodingOrNull requires a seekable stream. Encoding detection requires reading the first four bytes. The stream is advanced, then rewound. Fine for a FileStream, but not for a DeflateStream, as when the xml is being read with System.IO.Compression.ZipArchive. SO. If the caller has provided an encoding: use it, skip trying to suss out the actual stream encoding, and absolutely avoid writing to the position property of the stream.
xoofx
force-pushed
the
support-unseekable-streams
branch
from
March 12, 2026 19:46
8b6adfb to
3710753
Compare
Owner
|
Good catch, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DetectEncodingOrNull requires a seekable stream. Encoding detection requires reading the first four bytes. The stream is advanced, then rewound. Fine for a FileStream, but not for a DeflateStream, as when the xml is being read with System.IO.Compression.ZipArchive.
SO. If the caller has provided an encoding: use it, skip trying to suss out the actual stream encoding, and absolutely avoid writing to the position property of the stream.