Added some FUSE functionalities for macOS#290
Open
tiberiu04 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces initial macOS support for rencfs FUSE mounting by leveraging the fuser crate instead of a dummy implementation.
- Implements macOS-specific mount logic (macos_impl module) using the fuser crate.
- Provides conditional compilation to separate macOS from non-macOS implementations.
- Updates Cargo.toml to include the fuser dependency for macOS.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mount/dummy.rs | Added macOS-specific mount implementation using the fuser crate. |
| Cargo.toml | Added dependency on the fuser crate for macOS target OS. |
Files not reviewed (2)
- data/contents/1/hash/$.: Language not supported
- data/contents/1/ls/$.: Language not supported
Comments suppressed due to low confidence (2)
src/mount/dummy.rs:104
- [nitpick] Consider renaming 'DummyFS' to a name that better conveys its temporary or placeholder nature for future production usage, to reduce any potential confusion during debugging.
struct DummyFS;
src/mount/dummy.rs:49
- New macOS FUSE mounting functionality introduced here lacks automated tests. Please consider adding tests to cover both mounting and unmounting scenarios.
async fn mount(self) -> FsResult<crate::mount::MountHandle> {
tiberiu04
commented
Apr 26, 2025
Author
tiberiu04
left a comment
There was a problem hiding this comment.
When building fuser was causing errors because I added the tokio feature. I removed it and now the build works just fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Add macOS FUSE support using
fusercrate #4Description
This PR adds initial support for macOS by replacing the previous dummy implementation with a real FUSE mount logic using the
fusercrate. This allows therencfsencrypted file system to be mounted and used on macOS, similar to how it works on Linux.dummy.rsfor macOS.MountPointImplandMountHandleInnerImplusingfuseron macOS.Fixes #4
Type of change
Checklist:
Additional Context
DummyFSis used temporarily; next step would be integratingEncryptedFsas a realFilesystemimplementation for macOS.macFUSEinstalled.