copy_file_range: prevent size-mismatch when copying large files#297
Open
CatalinaLeca wants to merge 1 commit into
Open
copy_file_range: prevent size-mismatch when copying large files#297CatalinaLeca wants to merge 1 commit into
CatalinaLeca wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR re-implements EncryptedFs::copy_file_range to copy data in blocks not exceeding the cipher’s maximum plaintext length, thereby preventing size-mismatch errors when copying large files.
- Replaces the old copy_file_range implementation with a block-based copying mechanism
- Renames the parameter "file_range_req" to "req" for brevity
- Adds inline comments to clarify safety guards and block handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
EncryptedFs::copy_file_rangeto copy in blocks not larger thancipher.max_plaintext_len(), eliminating partial writes.Why
“size mismatch write … 262144”.
Fixes #232