Repository navigation
fix(qualification): overlay control anchors on bottom/left/right; own broker for raw control (D46, TIN-6654) - #140
Merged
Jess Sullivan (Jesssullivan) merged 1 commit intoOct 18, 2026
Conversation
…ght; own broker for the raw control (D46, TIN-6654) The macOS menu bar draws above the Host overlay, so on a target whose menu bar is visible the control's top ring is menu bar (PZM 2026-10-18: top 45/5120 tinted, bottom 5120/5120, left and right 2767/2880) and the old every-side rule could never anchor. Require bottom, left and right; report the top ring and the best band below the menu bar without gating on it. A control without the overlay, or missing a required side, stays unanchored. overlay_600's raw control session can now use its own broker (--control-socket): one broker refuses two profiles for the same desktop, and that guard is unchanged. Part of TIN-5511. Related to TIN-6639, TIN-6654.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements operator ruling D46 (Linear TIN-5509, comment 90d4a0c8) and fixes TIN-6654.
Anchor rule (D46)
The attended 600-frame gate on the alpha.12/native.2 candidates (TIN-5511, comment 341b7282) gave these results:
unanchoredanyway. macOS draws the menu bar above the Host overlay, so the raw-VNC control's top ring is menu bar: 45/5120 tinted, against bottom 5120/5120 and left/right 2767/2880.The old "≥ 50% on every side" rule can never anchor on a target whose menu bar is visible, and the target profile requires a visible menu bar.
What changes:
CONTROL_REQUIRED_SIDES).topBelowMenuBar: the most-tinted ring-high band within the top 4% of the frame. That band is diagnostic only, because the feather is already faint there. At the dimmest heartbeat it falls below the edge-band thresholds.unanchored.Raw control on its own broker (TIN-6654)
createBrokerrejects two profiles for one desktop, sooverlay_600could not open its raw control session on the Host broker.What changes:
--control-socketgives the control session its own observation-only broker. It defaults to--socket.targetIdwith the Host profile.Validation
npm test: 857/857 on Node 24.21.0, including a new menu-bar control test that covers the fail-closed cases.docs:check: passes.Part of TIN-5511. Related to TIN-6639, TIN-6654.