Conversation
… handling - S7497: Use finally block instead of except + raise for CancelledError (event_bus, redis_pubsub, agent_tasks) - S7493: Use sync file read in executor via helper functions (local, workspace_tools) - S7503: Remove async keyword from nested read_file helper These patterns avoid introducing new issues while maintaining proper async behavior.
- RightPanel.tsx: Replace parseInt with Number.parseInt, isNaN with Number.isNaN - Follows modern JS best practices
…oats, S2201/S1764 - S6853 (46): Form labels without associated control - removed ineffective comments - S6848 (20): Non-interactive DOM handlers - removed ineffective comments - S1244 (8): Floating point equality - use pytest.approx() in tests - S2201 (1): Unused dict.get() return value in papers.py - S1764 (1): Identical expression on both sides of 'or' in test_prompts.py - S7773: Number.parseInt/isNaN (already pushed) eslint now passes with warnings only.
The helper function _read_file_lines is sync, so it must be called via run_in_executor when in an async context. Calling directly broke tests. Also fixes workspace_tools.py to use correct pattern.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.