Repository navigation
Faster rebin xafs (+ dev tools update) - #638
Merged
Merged
Conversation
newville
approved these changes
Oct 2, 2026
newville
left a comment
newville
left a comment
Member
There was a problem hiding this comment.
Thanks -- that looks interesting and I can certainly believe it is faster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@newville I found
rebin_xafs()rather slow when rebinning large dataset automatically. I asked Claude to implement a vectorized form of it. For theboxcarmethod this improves speed enormously (you can check it via the related test file).Furthermore, I added type hinting and I had to improve the [dev] target in order to get it automatically checked by mypy.
I have not checked the Larix GUI side yet.