fix(clipcatctl): fix output ordering of list cmd#1054
Open
james64 wants to merge 1 commit into
Open
Conversation
9c581ae to
e6cf00b
Compare
e6cf00b to
51e2183
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this is a fix for #1053 . Output is not stable becuase fresh instance of
tokio::io::stdoutis created insideforloop for ever entry. Eachstdouthas its dedicated worker creating a race condition. Creating single instance outside the loop solves the problem. See commentary in tokio doc. I have tested it locally and the problem is gone.Let me know if I need to update anything 👍