experiment with new group id#219
Conversation
|
|
||
| val ComparableVersion currentXtextVersion = new ComparableVersion(version); | ||
| val ComparableVersion targetVersion = new ComparableVersion("2.40.0") | ||
| if (currentXtextVersion >= targetVersion) { |
There was a problem hiding this comment.
@oehme while we are parallel investigating with relocations on maven side, wdyt about this approach
There was a problem hiding this comment.
hmmm no idea why xtextVersion.getVersion crashes
There was a problem hiding this comment.
The xtextVersion variable is determined from the dependencies, so you can't determine the dependencies from the Xtext version. Chicken-egg problem :)
| //if (currentXtextVersion >= targetVersion) { | ||
| val m1 = module('''org.eclipse.xtend:org.eclipse.xtend.core:>=2.40.0'''.toString()); | ||
| val m2 = module('''org.eclipse.xtext:org.eclipse.xtend.core'''.toString()); | ||
| //substitute(m1).using(m2) |
There was a problem hiding this comment.
problem seems to be we need a target version for the substitute here too
There was a problem hiding this comment.
ofc wont work cause it runs too early
|
|
have no clue why it harms the test even if it is not going into my replacer |
| java-version: ${{ matrix.java }} | ||
| - name: Build | ||
| uses: eskatos/gradle-command-action@v1 | ||
| uses: gradle/gradle-build-action@v2 |
There was a problem hiding this comment.
i assume the other wf needs change too
| with: | ||
| arguments: build | ||
| dependencies-cache-enabled: true | ||
| cache-read-only: ${{ github.ref != 'refs/heads/master' }} |
There was a problem hiding this comment.
no idea which config we want here
2 participants
No description provided.