Repository navigation
fix: 3 bug fixes + remove dead code from deep review - #9
Merged
Merged
Conversation
BUG-1 (audio_cleaning.py): low_snr_retry_recommended warning was emitted for all SNR < 20 dB instead of only SNR < 8 dB — the warning was at the wrong indentation level. BUG-2 (streaming_inference.py): ThreadPoolExecutor instances were never shut down, leaking threads on session teardown. Added _shutdown_executors() called from __del__. BUG-3 (streaming_inference.py): current_word_index was always None because _emitted_sentence_words was never consulted. Added index tracking after the sentence_words comprehension. Dead code removed: - get_json() / set_json() from redis_bus.py (never called) - 4 modules: word_identity_calibration, vector_index, vector_sync, sentence_repository (only referenced by their own tests/scripts) - 3 test files and 3 scripts that exercised the removed modules All 127 existing tests pass after these changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG-1 (audio_cleaning.py): low_snr_retry_recommended warning was emitted for all SNR < 20 dB instead of only SNR < 8 dB — the warning was at the wrong indentation level.
BUG-2 (streaming_inference.py): ThreadPoolExecutor instances were never shut down, leaking threads on session teardown. Added _shutdown_executors() called from del.
BUG-3 (streaming_inference.py): current_word_index was always None because _emitted_sentence_words was never consulted. Added index tracking after the sentence_words comprehension.
Dead code removed:
All 127 existing tests pass after these changes.