get_active_window gives back None sometimes#5
Open
kgabor545 wants to merge 1 commit intoxuzhen:pygi-python3from
Open
get_active_window gives back None sometimes#5kgabor545 wants to merge 1 commit intoxuzhen:pygi-python3from
kgabor545 wants to merge 1 commit intoxuzhen:pygi-python3from
Conversation
…ons especially with mouse wheel prev/next window. Better have prev window active than none, so the flickering is gone
Owner
|
What's your desktop environment or window manager? I can't reproduce the flickering bug. |
Author
|
I am on arch xfce. I am currently using the xfce4 panel version of dockx, but the flickering was always here for me with native dockx too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
especially with mouse wheel set to prev/next window on group.
This caused group has active window false, making the group active, inactive and active again, caused flickering
Better have prev window as active than none, so the flickering is gone.
As I tested everything works well with this patch, I hope I didn't break anything else with this.