Skip to content

fix: apply swift-format strict lint baseline across all Swift files#15

Draft
Copilot wants to merge 3 commits intomasterfrom
copilot/fix-swift-format-issues
Draft

fix: apply swift-format strict lint baseline across all Swift files#15
Copilot wants to merge 3 commits intomasterfrom
copilot/fix-swift-format-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 5, 2026

  • Explored repository structure and identified formatting issues
  • Created .swift-format configuration with 4-space indentation
  • Ran swift format format --in-place on Package.swift, Sources/, and Tests/
  • Ran formatter on PromptRefactorApp Swift files
  • Renamed GroqModel enum cases to proper lowerCamelCase (llama318bInstant, llama3370bVersatile)
  • Verified all files pass swift format lint --strict (exit code 0)
  • Resolved merge conflict by incorporating master's functional changes:
  • All 9 tests pass with no regressions
Original prompt

This section details on the original issue you should resolve

<issue_title>Repository fails strict swift-format lint baseline</issue_title>
<issue_description>## Problem
The repository currently fails the documented strict formatter checks, including indentation, trailing commas, and line-length findings across package, source, and test files.

Impact

  • Style drift and noisy diffs.
  • Harder code reviews and inconsistent contributor experience.
  • CI lint adoption is blocked until baseline is fixed/suppressed.

Evidence

Commands run from repo root:

  • swift format lint --strict Package.swift
  • swift format lint --strict --recursive Sources Tests PromptRefactorApp

Both return many violations.

Recommendation

  • Run swift format format --in-place across tracked Swift files and commit as a dedicated formatting pass.
  • Optionally add a formatter configuration and CI gate to prevent drift.
  • If full reformat is too large, phase by module with temporary lint scope controls.</issue_description>

<agent_instructions>fix the lintering issue and ensure readability</agent_instructions>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

- Add .swift-format config with 4-space indentation
- Format all Swift files (trailing commas, line length, indentation)
- Rename GroqModel enum cases to proper lowerCamelCase

Co-authored-by: xvvcs <121556996+xvvcs@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix repository strict swift-format lint baseline fix: apply swift-format strict lint baseline across all Swift files Mar 5, 2026
Copilot finished work on behalf of xvvcs March 5, 2026 12:38
@xvvcs
Copy link
Copy Markdown
Owner

xvvcs commented Mar 5, 2026

@copilot Resolve the merge conflict in the codebase while preserving core functionalities, ensuring no regressions or disruptions to existing features.

- Preserve parenthesized content in clarifyPrompt (from PR #16)
- Fix accessibility polling loop task cancellation (from PR #14)
- Update and add tests for clarifyPrompt behavior

Co-authored-by: xvvcs <121556996+xvvcs@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 5, 2026

@copilot Resolve the merge conflict in the codebase while preserving core functionalities, ensuring no regressions or disruptions to existing features.

Resolved in da89a79. The merge conflict was caused by two PRs that had been merged into master:

All 9 tests pass and swift format lint --strict still exits 0 for all targets.

Copilot finished work on behalf of xvvcs March 5, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repository fails strict swift-format lint baseline

2 participants