Make encode of VersionedCodec transactional#161
Open
cdelabou wants to merge 1 commit intoxxfast:masterfrom
Open
Make encode of VersionedCodec transactional#161cdelabou wants to merge 1 commit intoxxfast:masterfrom
cdelabou wants to merge 1 commit intoxxfast:masterfrom
Conversation
cdelabou
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versioned codec has not been included in #100 and still suffer from corrupted data on error (had the case with a map whose value failed to encode, decoding could never succeed afterwards).
This applies a similar approach to prevent any change on serialization error :)