fix: add 'folder' param to Cloudinary upload options#1
Open
tsy-fred wants to merge 1 commit into
Open
Conversation
The plugin was only passing 'public_id' with the full path (e.g. 'my-website/test/md5hash'), which caused all uploaded images to appear under 'Home' in Cloudinary's Media Library Browser view, ignoring the user-configured folder. Fix by passing the path as the 'folder' parameter and the hash as the 'public_id' separately, so Cloudinary properly organizes assets into the specified folder in its Media Library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using the
folderconfig (akauploadPath), the plugin was constructing thepublic_idasfPath + "/" + hashfNamewithout passing thefolderparameter separately.This caused all uploaded images to appear under "Home" in Cloudinary's Media Library Browser view, ignoring the user-configured folder structure.
Change
Split the path into two Cloudinary upload API parameters:
folder=fPath(the user-configured folder path)public_id=hashfName(the md5 hash filename)Cloudinary's Media Library uses the
folderparameter to organize assets in its Browser view, so this fix ensures images appear in the correct folder.Testing
Tested locally with PicGo:
foldertomy-website/testmy-website/test/in Cloudinary Media Library Browser viewsecure_urlreturned correctly ✅