Skip to content

fix: add path validation in pushme.js #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add path validation in pushme.js #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion bin/pushme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ function copyDir(src, dest) {
}
}

/**
* 校验目标目录是否安全（禁止路径穿越）
*/
function isSafeTargetDir(dir) {
if (!dir || dir === '.') return true;
return !dir.split(/[\\/]/).includes('..');
}

/**
* 初始化项目到指定目录
*/
Expand Down Expand Up @@ -188,6 +196,10 @@ const command = process.argv[2];
if (command === 'init') {
const targetDir = process.argv[3];
if (targetDir) {
if (!isSafeTargetDir(targetDir)) {
log.error('目录名不合法：不允许包含路径穿越字符 ".."');
process.exit(1);
}
init(targetDir);
} else {
// 动态提示用户输入
Expand All @@ -197,7 +209,12 @@ if (command === 'init') {
});
rl.question(` ${c.blue}›${c.reset} 请输入项目目录名 ${c.dim}(直接回车在当前目录初始化)${c.reset}: `, (answer) => {
rl.close();
init(answer.trim() || '.');
const dir = answer.trim() || '.';
if (!isSafeTargetDir(dir)) {
log.error('目录名不合法：不允许包含路径穿越字符 ".."');
process.exit(1);
}
init(dir);
});
}
} else if (command === 'start') {
Expand Down