Create Is Subsequence.md#7
Open
yakataN wants to merge 1 commit into
Open
Conversation
skypenguins
reviewed
Jul 27, 2025
| return True | ||
|
|
||
| seen = 0 | ||
| for char_t in t: |
There was a problem hiding this comment.
char_t は型と一瞬見間違えるので単に c でも良いと思います。
nodchip
reviewed
Jul 27, 2025
| # 終了判定を挟む必要があり、そこをわかりやすくかけるかどうかでindexの扱いを変えたい | ||
| if len(s) == 0: | ||
| return True | ||
| seen = 0 |
There was a problem hiding this comment.
seen という変数名から、どのような値が格納されているのか分かりづらく感じました。 step2 の s_index のほうが分かりやすく感じました。
hroc135
reviewed
Jul 28, 2025
|
|
||
| if s[s_index] == t[t_index]: | ||
| return traverse(s_index + 1, t_index + 1) | ||
| else: |
There was a problem hiding this comment.
再帰スッキリかけていて読みやすかったです。
強いて言えばここの else はなくてもいいですね
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem:
https://leetcode.com/problems/is-subsequence
Next problem:
https://leetcode.com/problems/word-break/