Metrics switchover#264
Merged
Merged
Conversation
dodokek
force-pushed
the
metrics_switchover
branch
3 times, most recently
from
19cefbd to
c52c7ef
Compare
dodokek
force-pushed
the
metrics_switchover
branch
from
55554ab to
ee634d0
Compare
added 2 commits
June 8, 2026 13:59
teem0n
requested changes
Jun 9, 2026
| if since.IsZero() { | ||
| since = start | ||
| } | ||
| app.logTiming(timingSwitchover+"_failure", -time.Since(since)) |
Contributor
There was a problem hiding this comment.
We should call time.Since in the very beginning of the method
Otherwise, we will measure switchover time + 2 zk calls (getTimingStart + clearTiming), and this may take a non-zero time
teem0n
reviewed
Jun 9, 2026
| app.logger.Info().Msgf("switchover: %s => %s starting...", switchover.From, switchover.To) | ||
| switchover.StartedAt = time.Now() | ||
| switchover.StartedBy = app.config.Hostname | ||
| if switchover.MasterTransition == SwitchoverTransition { |
Contributor
There was a problem hiding this comment.
Switchover may be started from external source
Collaborator
Author
There was a problem hiding this comment.
Looking at InitiatedAt field then
teem0n
requested changes
Jun 9, 2026
teem0n
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write info about switchover timings and other rare stuff