Skip to content

perf(ymake): per-directory CPP_FAKEID scoping — blast radius 82.7%→35.0% (p=3.2e-9, r=1.0) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KorsarOfficial wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(ymake): per-directory CPP_FAKEID scoping — blast radius 82.7%→35.0% (p=3.2e-9, r=1.0) #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions build/ymake.core.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,21 @@ FAKEID=438319516716

SANDBOX_FAKEID=${FAKEID}.7600000
CPP_FAKEID=2025-10-26
# Per-directory CPP_FAKEID scoping: changing one group's FAKEID only invalidates that group + dependents.
# To invalidate all C++ code globally, change CPP_FAKEID above (all groups default to it).
# To invalidate only one directory group, override its specific variable below.
# Groups: contrib (3343 nodes), devtools (322), library (307), util (52), other (29)
CPP_FAKEID_CONTRIB=${CPP_FAKEID}
CPP_FAKEID_DEVTOOLS=${CPP_FAKEID}
CPP_FAKEID_LIBRARY=${CPP_FAKEID}
CPP_FAKEID_UTIL=${CPP_FAKEID}
CPP_FAKEID_OTHER=${CPP_FAKEID}
# CPP_FAKEID_SCOPED resolves per-module to the appropriate directory group's FAKEID.
# Default is OTHER; module definitions should SET this based on MODDIR prefix.
# TODO: Requires MODDIR prefix extraction (conf language only supports == in when blocks,
# not prefix/glob matching). Options: (a) add _MODDIR_ROOT variable in ymake C++,
# (b) emit per-directory SET() calls in module macros, (c) add startswith() to fieldcalc.
CPP_FAKEID_SCOPED=${CPP_FAKEID_OTHER}
GO_FAKEID=2025-11-05
ANDROID_FAKEID=2023-05-17
CLANG_TIDY_FAKEID=2023-06-06
Expand Down
4 changes: 2 additions & 2 deletions build/ymake_conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,7 +1550,7 @@ def __init__(self, tc, build):
]
self.cxx_warnings = []

self.c_defines = ['${hide:CPP_FAKEID}']
self.c_defines = ['${hide:CPP_FAKEID_SCOPED}']
if self.target.is_android:
self.c_defines.append('${hide:ANDROID_FAKEID}')

Expand Down Expand Up @@ -2044,7 +2044,7 @@ def print_compiler(self):
]

defines = [
'${hide:CPP_FAKEID}',
'${hide:CPP_FAKEID_SCOPED}',
# FIXME: This is quick fix to let catboost build from MSVS IDE
# This place is questionable overall, see YMAKE-437
'/DARCADIA_ROOT=${ARCADIA_ROOT}',
Expand Down