Skip to content

fix(web-search): stop inactivity timer after terminal - #312

Merged
yansigit merged 1 commit into
devfrom
codex/web-search-terminal-drain-timeout
Sep 7, 2026
Merged

fix(web-search): stop inactivity timer after terminal#312
yansigit merged 1 commit into
devfrom
codex/web-search-terminal-drain-timeout

Conversation

@yansigit

@yansigit yansigit commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Stop the web-search response-byte inactivity timer after an adapter emits a terminal event.
  • Keep the distinct post-terminal drain timeout responsible for bounded iterator cleanup.
  • Make the regression deterministic by draining longer than the pre-terminal inactivity window.

Verification

  • bun test tests/web-search/web-search-progress-stream.test.ts (21 pass)
  • bun run typecheck
  • bun run test:changed (20,610 pass, 17 skip, 0 fail)
  • Independent code review: approved with no concerns.
  • Production config SHA-256, mtime, mode, and invalid/backup inventory remained unchanged before and after tests.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Added/updated tests for behavior changes under src/ or gui/src/, or obtained test-exception-approved (check: bun run check:hygiene).
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

No documentation update is needed because this fixes internal timeout ownership without changing configuration or public behavior.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

PR automation (bot-owned)

  • Class: same-repo-human (same-repo-human)
  • Base: e00690fea4730f1aa6234b1d81ef11dbaf27361c
  • Head: ad17cfd708afd3ff326cd81ad7432a05163025cf
  • Action: observed
  • Exact-head gate: PASS
  • Sensitive paths: none
  • Maintainer auto-merge approval: NO
  • Bot merge evidence: NO
  • Next action: wait for exact-head checks

@github-actions github-actions Bot added the bug Something isn't working label Sep 7, 2026
@yansigit
yansigit merged commit 16a75ac into dev Sep 7, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant