[codex] Skip Windows Node 26 until MSVC build flags are fixed#275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-latest+26.xmatrix entry from test and release workflows.Context
The Node 22/24/26 matrix update landed on
master, but thetestworkflow failed only onbuild (26.x, windows-latest)duringnpm ci. The fallback source build reaches MSVC, then fails because Node 26.3.0 headers inject clang ThinLTO options into the generated Visual Studio project:The other 11 matrix entries passed. An attempted local
binding.gypflag removal andnpm_config_force_process_configworkaround did not prevent node-gyp from reading the Node 26 headercommon.gypion Windows, so this PR uses a narrow matrix exclusion until the upstream Node/node-gyp/MSVC flag handling is fixed.Validation
testmatrix on this PR.