Skip to content

[codex] Update cppjieba submodule#42

Merged
yanyiwu merged 1 commit into
masterfrom
codex/update-cppjieba-2026-06-08
Jun 8, 2026
Merged

[codex] Update cppjieba submodule#42
yanyiwu merged 1 commit into
masterfrom
codex/update-cppjieba-2026-06-08

Conversation

@yanyiwu

@yanyiwu yanyiwu commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Summary

Update submodules/cppjieba from b3602bef to 3503cb3b.

This brings in the current limonp LocalVector compatibility wrapper, the explicit <cassert> dependency fix, Bazel smoke coverage, and the latest cppjieba CI/test updates.

Validation

Run from an in-repository build directory because the existing tests use relative source paths:

  • cmake -S . -B build -DCMAKE_BUILD_TYPE=Release
  • cmake --build build --parallel 2
  • ctest --test-dir build --output-on-failure

Result: 2/2 tests passed.

@jingmin111

jingmin111 commented Jun 8, 2026 via email

Copy link
Copy Markdown

@yanyiwu yanyiwu marked this pull request as ready for review June 8, 2026 03:29
@yanyiwu yanyiwu merged commit 092f696 into master Jun 8, 2026
112 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b9d8809d7d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread submodules/cppjieba
@@ -1 +1 @@
Subproject commit b3602bef7d1f67521a61788a74fb5801a0e62cd3
Subproject commit 3503cb3bc44405d940420cc714b0d217d481ff53

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve LocalVector's small-buffer behavior

When simhash segments any non-empty document, cppjieba's Trie::Find builds one Dag per rune and immediately appends to Dag::nexts; this submodule revision pulls in limonp 4065c5f, where LocalVector is now a plain std::vector with no inline capacity. That turns the first append for almost every character into a heap allocation instead of using the previous 16-element stack buffer, so common make()/extract() calls allocate O(text length) more and can significantly slow large-document processing. Please keep the old small-buffer behavior or reserve/replace this hot-path container before bumping cppjieba.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants