feat: add vtdnntts-eu.readspeaker to connect directive#37
Closed
laravdiemen wants to merge 1 commit into
Closed
Conversation
laravdiemen
requested review from
Rovasch,
ShunLuk,
SimonvanWijhe,
Copilot,
dtakken,
ictbeheer,
mvdhoek1 and
rivanuff
There was a problem hiding this comment.
Pull request overview
This PR updates the Basic CSP policy to allow an additional ReadSpeaker EU endpoint that has started being used, preventing CSP connect-src violations for sites using ReadSpeaker.
Changes:
- Add
https://vtdnntts-eu.readspeaker.comto the ReadSpeakerconnect-srcallowlist.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // ReadSpeaker | ||
| ->addDirective(Directive::CONNECT, ['https://cdn-eu.readspeaker.com', 'https://app-eu.readspeaker.com', 'https://vttts-eu.readspeaker.com', 'https://media-eu.readspeaker.com']) | ||
| ->addDirective(Directive::CONNECT, ['https://cdn-eu.readspeaker.com', 'https://app-eu.readspeaker.com', 'https://vttts-eu.readspeaker.com', 'https://media-eu.readspeaker.com', 'https://vtdnntts-eu.readspeaker.com']) |
There was a problem hiding this comment.
This CONNECT directive line is getting very long; consider formatting the allowed ReadSpeaker endpoints as a multi-line array (consistent with other multi-line directives in this file) to keep diffs readable and make future additions easier.
Suggested change
| ->addDirective(Directive::CONNECT, ['https://cdn-eu.readspeaker.com', 'https://app-eu.readspeaker.com', 'https://vttts-eu.readspeaker.com', 'https://media-eu.readspeaker.com', 'https://vtdnntts-eu.readspeaker.com']) | |
| ->addDirective( | |
| Directive::CONNECT, | |
| [ | |
| 'https://cdn-eu.readspeaker.com', | |
| 'https://app-eu.readspeaker.com', | |
| 'https://vttts-eu.readspeaker.com', | |
| 'https://media-eu.readspeaker.com', | |
| 'https://vtdnntts-eu.readspeaker.com', | |
| ] | |
| ) |
rivanuff
approved these changes
Mar 27, 2026
Contributor
Author
|
Besloten om het met een wildcard op te lossen want anders blijven we bezig. Ik sluit deze PR en maak een nieuwe aan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ik dacht het gefixt te hebben in #34 maar nu heeft readspeaker weer een andere url bedacht.