Skip to content

a11y: remove role navigation from facetwp pager #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laravdiemen merged 1 commit into from
Dec 19, 2025
Merged

a11y: remove role navigation from facetwp pager #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/modules/A11yFacetWP.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export class A11yFacetWP {
* This timeout is necessary because otherwise it will be called too early
*/
setTimeout( () => {
this.removeRoleNavigationFromPager();
this.addAriaCurrentToPager();
this.changeAriaLabelSelections();
}, 1 );
Expand Down Expand Up @@ -96,6 +97,18 @@ export class A11yFacetWP {
}
}

/**
* A11y: remove 'role=navigation' from FacetWP pager if it is inside a <nav> element.
*/
private removeRoleNavigationFromPager(): void {
const pager = document.querySelector( '.facetwp-pager' );
if ( ! pager ) return;

if ( pager.parentElement?.tagName.toLowerCase() === 'nav' ) {
pager.removeAttribute( 'role' );
}
}

Comment on lines +100 to +111
Copy link
Copy Markdown
Contributor

@WybeBosch WybeBosch Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh right hier had je JS nodig omdat facetwp zelf die "role" zette. Helder.

/**
* A11y: add 'aria-current' attribute to FacetWP pager.
*/
Expand Down