Skip to content

feat: strip new tab notice from excerpts / make new tab notice config… #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yannicvanveen merged 3 commits into from
Apr 3, 2026
Merged

feat: strip new tab notice from excerpts / make new tab notice config… #57

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b143a36
feat: strip new tab notice from excerpts / make new tab notice config…
Yannicvanveen Apr 1, 2026
f748974
feat: remove leading space from default notice
Yannicvanveen Apr 1, 2026
489b529
feat: add early return if excerpt does not contain new tab notice / a…
Yannicvanveen Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion src/Theme.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ class Theme
{
use ParentPage;

private string $newTabNotice;

public function __construct()
{
$this->newTabNotice = config('theme.a11y_new_tab_notice', __('(opent in nieuw tabblad)', 'sage'));
}

/**
* Disable WordPress from changing smilies (also known as smileys) into emojis.
*
Expand Down Expand Up @@ -198,7 +205,7 @@ public function filterA11yProblematicHtmlTags(string $content): string
}

try {
$srOnlySpan = $doc->createElement('span', ' (opent in nieuw tabblad)');
$srOnlySpan = $doc->createElement('span', ' ' . $this->newTabNotice);
} catch (\DOMException $e) {
continue;
}
Expand Down Expand Up @@ -236,6 +243,25 @@ public function filterA11yProblematicHtmlTags(string $content): string
return '' === $newContent ? $content : $newContent;
}

/**
* Strips the new tab notice from excerpts and removes the extra space
*/
#[Filter('get_the_excerpt')]
public function stripNewTabNoticeFromExcerpt(string $excerpt, \WP_Post $post): string
{
if (has_excerpt($post)) {
return $excerpt;
}

$strippedExcerpt = str_replace($this->newTabNotice, '', $excerpt);

if ($strippedExcerpt === $excerpt) {
return $excerpt;
}

return preg_replace('/\s{2,}/', ' ', trim($strippedExcerpt)) ?? $strippedExcerpt;
}

/**
* Remove the outer div that was added for fragment safety.
*/
Expand Down
Loading