refactor: adopt extended-acf fieldgroup registration#26
Merged
Conversation
|
Coverage report for commit: bdc574f Summary - Lines: 78.72% | Methods: 22.22%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||
ece2700 to
3eb7f2a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the scaffolded ACF field group registration approach by replacing ACF Local JSON stub exports with PHP-based field group classes using Extended ACF + yard/wp-acf-registrar, and updates the publish mappings accordingly.
Changes:
- Remove ACF Local JSON field group stubs for Person, Project, and Knowledgebase.
- Add new
App\FieldGroups\{Person,Project,Knowledgebase}PHP classes extendingYard\Acf\Registrar\FieldGroup. - Update
ScaffoldServiceProviderpublish tags to publish the new FieldGroups instead ofacf-json/*.jsonfiles.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| stubs/acf-json/group_66e02ff47667d.json | Removes Person field group JSON export stub. |
| stubs/acf-json/group_66e0254a243fe.json | Removes Project field group JSON export stub. |
| stubs/acf-json/group_66e0254a243fd.json | Removes Knowledgebase field group JSON export stub. |
| stubs/FieldGroups/Project.php | Adds PHP-based Project field group definition via Extended ACF. |
| stubs/FieldGroups/Person.php | Adds PHP-based Person field group definition via Extended ACF. |
| stubs/FieldGroups/Knowledgebase.php | Adds PHP-based Knowledgebase field group definition via Extended ACF. |
| src/ScaffoldServiceProvider.php | Updates publish mappings to publish FieldGroups PHP instead of ACF JSON. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
laravdiemen
approved these changes
Apr 14, 2026
rivanuff
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject to merge and release of yardinternet/brave-acf#1 and yardinternet/wp-acf-registrar#15Need to opensource brave-acf and wp-acf-registrarReady for review :)