Skip to content

refactor: adopt extended-acf fieldgroup registration#26

Merged
Rovasch merged 2 commits into
mainfrom
refactor/acf-registrar
Apr 14, 2026
Merged

refactor: adopt extended-acf fieldgroup registration#26
Rovasch merged 2 commits into
mainfrom
refactor/acf-registrar

Conversation

@Rovasch
Copy link
Copy Markdown
Contributor

@Rovasch Rovasch commented Mar 2, 2026

Subject to merge and release of yardinternet/brave-acf#1 and yardinternet/wp-acf-registrar#15

Need to opensource brave-acf and wp-acf-registrar

Ready for review :)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2026

Coverage report for commit: bdc574f
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 75.0%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ████░░░░░░░░░░░░░░░░░░░ │ 12.5%
 100% │ ████░░░░░░░░░░░░░░░░░░░ │ 12.5%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 78.72% | Methods: 22.22%
FilesLinesMethodsBranches
src/Console
   ChildThemeScaffoldCommand.php87.50%-100.00%
   ElasticsearchScaffoldCommand.php--100.00%
   EventScaffoldCommand.php--100.00%
   KnowledgebaseScaffoldCommand.php--100.00%
   NewsScaffoldCommand.php--100.00%
   PersonScaffoldCommand.php--100.00%
   ProjectScaffoldCommand.php--100.00%
src
   ScaffoldServiceProvider.php100.00%100.00%100.00%

🤖 comment via lucassabreu/comment-coverage-clover

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the scaffolded ACF field group registration approach by replacing ACF Local JSON stub exports with PHP-based field group classes using Extended ACF + yard/wp-acf-registrar, and updates the publish mappings accordingly.

Changes:

  • Remove ACF Local JSON field group stubs for Person, Project, and Knowledgebase.
  • Add new App\FieldGroups\{Person,Project,Knowledgebase} PHP classes extending Yard\Acf\Registrar\FieldGroup.
  • Update ScaffoldServiceProvider publish tags to publish the new FieldGroups instead of acf-json/*.json files.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
stubs/acf-json/group_66e02ff47667d.json Removes Person field group JSON export stub.
stubs/acf-json/group_66e0254a243fe.json Removes Project field group JSON export stub.
stubs/acf-json/group_66e0254a243fd.json Removes Knowledgebase field group JSON export stub.
stubs/FieldGroups/Project.php Adds PHP-based Project field group definition via Extended ACF.
stubs/FieldGroups/Person.php Adds PHP-based Person field group definition via Extended ACF.
stubs/FieldGroups/Knowledgebase.php Adds PHP-based Knowledgebase field group definition via Extended ACF.
src/ScaffoldServiceProvider.php Updates publish mappings to publish FieldGroups PHP instead of ACF JSON.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread stubs/FieldGroups/Project.php
Comment thread stubs/FieldGroups/Knowledgebase.php
@Rovasch Rovasch merged commit c4ab74c into main Apr 14, 2026
5 checks passed
@Rovasch Rovasch deleted the refactor/acf-registrar branch April 14, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants