Feat/improvements#29
Merged
Merged
Conversation
laravdiemen
requested review from
FreakyWizard,
JasperS20,
Rovasch,
ShunLuk,
SimonvanWijhe,
WybeBosch,
Yannicvanveen,
YvetteNikolov,
dtakken,
ictbeheer,
mvdhoek1 and
rivanuff
|
Coverage report for commit: f510715 Summary - Lines: 78.72% | Methods: 22.22%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the scaffolded Blade templates and FacetWP config to improve event location rendering, simplify card list layouts, and adjust the events template filter to include ongoing events.
Changes:
- Update event-info location block to handle online events, venues, and unknown locations explicitly.
- Refactor several “related items”/listing sections and FacetWP loops to new layout classes (
auto-grid,flex flex-col). - Update FacetWP events template filter to use
cf/event_end_datefor date cutoff logic.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| stubs/sage-child/resources/styles/base/config.css | Removes the sample primary color palette overrides from the child theme Tailwind @theme block. |
| stubs/resources/views/vendor/wp-events/blocks/event-info.blade.php | Refactors location rendering (online/venue/unknown) and Google Maps link handling. |
| stubs/resources/views/single-yard-event.blade.php | Replaces container-query grid markup with auto-grid for related event cards. |
| stubs/resources/views/single-yard-event-schedule.blade.php | Replaces explicit grid utilities with auto-grid for schedule event cards. |
| stubs/resources/views/single-project.blade.php | Switches child/related project card containers to auto-grid. |
| stubs/resources/views/single-news.blade.php | Switches related news card container to auto-grid. |
| stubs/resources/views/blocks/FacetWP/loops/project-loop.blade.php | Changes loop container from grid to flex flex-col while keeping gap utilities. |
| stubs/resources/views/blocks/FacetWP/loops/news-loop.blade.php | Changes loop container from grid to flex flex-col. |
| stubs/resources/views/blocks/FacetWP/loops/knowledgebase-loop.blade.php | Changes loop container from grid to flex flex-col. |
| stubs/resources/views/blocks/FacetWP/loops/events-loop.blade.php | Changes loop container from grid to flex flex-col. |
| stubs/config/facetwp/templates/events.php | Changes the meta filter key from cf/event_start_date to cf/event_end_date. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <x-card.yard-event :postData="$related" /> | ||
| @endforeach | ||
| </div> | ||
| <div class="alignwide auto-grid mb-2 mt-4 xl:mt-6"> |
Contributor
Author
There was a problem hiding this comment.
Deze utility zit in brave, dus geen enkel probleem
| [ | ||
| 'source' => 'meta', | ||
| 'key' => 'cf/event_start_date', | ||
| 'key' => 'cf/event_end_date', |
YvetteNikolov
approved these changes
Apr 13, 2026
mvdhoek1
approved these changes
Apr 13, 2026
| </a> | ||
| </span> | ||
| @if ($eventData->isOnline()) | ||
| {!! $eventData->isOnlineLabel() !!} |
There was a problem hiding this comment.
De naamgeving van isOnlineLabel() lijkt erop te duiden dat er een boolean wordt terug gegeven.
Gaat dit goed en retourneert ie toch een string value?
Contributor
Author
There was a problem hiding this comment.
Nu je het zo zegt snap ik je verwarring, maar het metaveld heet zo dus hij returnt een string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paar kleine aanpassingen, zie de commits voor wat exact.