feat: pagination shared between facetwp and elasticsearch#30
Open
WybeBosch wants to merge 7 commits into
Open
Conversation
WybeBosch
requested review from
FreakyWizard,
JasperS20,
Rovasch,
ShunLuk,
SimonvanWijhe,
Yannicvanveen,
YvetteNikolov,
dtakken,
ictbeheer,
laravdiemen,
mvdhoek1 and
rivanuff
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Reactive Search (Elasticsearch) pagination styling to use shared CSS custom properties so it can visually align with other pagination (e.g., FacetWP), per the referenced issue.
Changes:
- Refactors pagination layout and button styling to use shared
--pagination-*CSS custom properties. - Updates hover/focus behavior to use the
hocusvariant and adds an active-state underline indicator. - Minor ordering/spacing tweaks (e.g., results info utilities order, pagination container margin, pagination info top margin).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+174
to
+183
| .yrs-pagination { | ||
| @apply mb-8; | ||
| } | ||
|
|
||
| .yrs-pagination-list { | ||
| @apply justify-end gap-x-2 gap-y-4; | ||
| @apply m-(--pagination-item-margin) justify-end gap-x-(--pagination-item-gap-x) gap-y-(--pagination-item-gap-y); | ||
| } | ||
|
|
||
| .yrs-pagination-button { | ||
| @apply size-10 min-h-10 min-w-10 p-2 text-black no-underline transition-all; | ||
| @apply relative size-(--pagination-item-size) rounded-(--pagination-item-radius) p-2 text-black no-underline transition-all; |
Contributor
Author
There was a problem hiding this comment.
Yep. THis is a scaffold. it moves to brave. always brave. its the brave scaffold. if these things arent there. THats your problem
Contributor
Author
There was a problem hiding this comment.
We have some post install steps. i could make one of them to tel you to make sure you have em in your variable.css hm
WybeBosch
force-pushed
the
feat/improve-pagination-styling
branch
from
44a74a0 to
e12d976
Compare
|
Coverage report for commit: 511010b Summary - Lines: 77.08% | Methods: 22.22%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||
WybeBosch
force-pushed
the
feat/improve-pagination-styling
branch
from
a6602d0 to
ab56b2d
Compare
ShunLuk
reviewed
May 19, 2026
ShunLuk
reviewed
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paginatie-stijlen maken nu gebruik van gedeelde CSS custom properties, zodat FacetWP en Elasticsearch paginatie visueel op elkaar aansluiten.
Zie ook: yardinternet/brave#119