Skip to content

fix: disable admin email check#76

Open
ictbeheer wants to merge 1 commit into
mainfrom
fix/admin-email-check
Open

fix: disable admin email check#76
ictbeheer wants to merge 1 commit into
mainfrom
fix/admin-email-check

Conversation

@ictbeheer
Copy link
Copy Markdown
Member

No description provided.

@ictbeheer ictbeheer requested review from a team, Rovasch, ShunLuk, SimonvanWijhe, Copilot, dtakken, mvdhoek1 and rivanuff and removed request for a team May 29, 2026 07:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

Coverage report for commit: 0ef21c1
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 90.7%
  10% │ ██░░░░░░░░░░░░░░░░░░░░░ │  4.7%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.3%
  90% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
 100% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.3%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 4.80% | Methods: 3.92%
FilesLinesMethodsBranches
src/ACF
   ACFServiceProvider.php--100.00%
src/ACF/Controllers
   ProtectionTypeController.php--100.00%
   WhitelistGroupController.php--100.00%
src/BranchViewer
   BranchViewer.php83.67%40.00%100.00%
   BranchViewerServiceProvider.php10.00%-100.00%
src/Cleanup
   CleanupServiceProvider.php--100.00%
   EnqueuedScriptsStyles.php--100.00%
   MapMetaCap.php--100.00%
src/Cleanup/Plugins
   BaseAbstract.php--100.00%
   SearchWP.php--100.00%
   Stream.php--100.00%
src
   ConfigExpanderServiceProvider.php--100.00%
src/Disable
   DisableAdminNotices.php--100.00%
   DisableComments.php--100.00%
   DisableEmojicons.php--100.00%
   DisableFeed.php--100.00%
   DisableHeaders.php--100.00%
   DisableOEmbedEndpoint.php--100.00%
   DisablePosts.php--100.00%
   DisableRoles.php--100.00%
   DisableServiceProvider.php--100.00%
   DisableUsersEndpoint.php--100.00%
src/Licenses/Contracts
   AbstractLicense.php--100.00%
   LicenseInterface.php100.00%100.00%100.00%
src/Licenses
   LicenseManager.php--100.00%
   LicensesServiceProvider.php--100.00%
src/Licenses/Plugins
   AdvancedCustomFieldsLicense.php--100.00%
   FacetWPLicense.php--100.00%
   GravityFormsLicense.php--100.00%
   GravitySMTPLicense.php--100.00%
   SearchWPLicense.php--100.00%
   SeoPressLicense.php--100.00%
   WpMigrateLicense.php--100.00%
src/LoginScreenCustomization
   LoginScreenCustomization.php--100.00%
   LoginScreenCustomizationServiceProvider.php--100.00%
src/Mail
   MailServiceProvider.php--100.00%
src/Protection
   Protect.php8.96%14.29%100.00%
   ProtectionServiceProvider.php--100.00%
   WhitelistEntity.php--100.00%
src/Support/Helpers
   WordPressEnvironment.php--100.00%
src/Support/Traits
   PluginActive.php--100.00%
   Route.php--100.00%
src/routes
   web.php-100.00%100.00%

🤖 comment via lucassabreu/comment-coverage-clover

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the “disable admin email check” configuration by ensuring the ADMIN_EMAIL_CHECK_INTERVAL setting is applied even when it is set to 0 (which was previously skipped due to empty(0) being true).

Changes:

  • Update the conditional guard for ADMIN_EMAIL_CHECK_INTERVAL from ! empty(...) to isset(...) so an interval of 0 is not ignored.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants